Bug 839091 - Review Request: kyua-atf-compat - ATF compatibility tools
Summary: Review Request: kyua-atf-compat - ATF compatibility tools
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-07-10 22:28 UTC by Julio Merino
Modified: 2014-08-13 11:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-13 11:55:09 UTC
Type: ---
Embargoed:
michel: fedora-review?


Attachments (Terms of Use)

Description Julio Merino 2012-07-10 22:28:41 UTC
Spec URL: ftp://ftp.NetBSD.org/pub/NetBSD/misc/jmmv/kyua-atf-compat/kyua-atf-compat.spec
SRPM URL: ftp://ftp.NetBSD.org/pub/NetBSD/misc/jmmv/kyua-atf-compat/kyua-atf-compat-0.1-1.fc17.src.rpm
Description:

Kyua (pronounced Q.A.) is a testing framework for both developers and
users.  Kyua is different from most other testing frameworks in that it
puts the end user experience before anything else.  There are multiple
reasons for users to run the tests themselves, and Kyua ensures that
they can do so in the most convenient way.

This module, kyua-atf-compat, provides tools to ease the transition from
ATF to Kyua.  In particular, this includes is a tool to convert Atffile
files to Kyuafile files in an automated manner, and drop-in replacement
wrappers for atf-run and atf-report.

Fedora Account System Username: jmmv

Comment 1 Michael Schwendt 2012-12-14 13:45:36 UTC
https://fedoraproject.org/wiki/Package_Review_Process
| 
| Wait for someone to review your package! At this point in the process,
| the fedora-review flag is blank, meaning that no reviewer is assigned.

An incorrectly/mistakably set fedora-review flag causes the ticket to be listed as being worked on by somebody.

Comment 2 Julio Merino 2013-02-19 18:26:45 UTC
Michel: I now realize I never CCd you on this. You may be interested :-P Thanks in advance!

Comment 3 Michel Lind 2013-03-18 07:47:42 UTC
Taking this review

Comment 4 Michel Lind 2013-03-19 14:15:50 UTC
When building in mock, make check fails

+ make check pkgtestsdir=/usr/libexec/kyua-atf-compat/tests testsdir=/usr/libexe
c/kyua-atf-compat/tests
make  check-local
make[1]: Entering directory `/builddir/build/BUILD/kyua-atf-compat-0.1'
KYUA_ATF_COMPAT_BINDIR='/builddir/build/BUILD/kyua-atf-compat-0.1' KYUA_ATF_COMP
AT_PKGDATADIR='/builddir/build/BUILD/kyua-atf-compat-0.1' PATH=/builddir/build/B
UILD/kyua-atf-compat-0.1:${PATH}  \
     test --build-root='.' \
            --kyuafile='./Kyuafile'
/bin/sh: line 0: test: --build-root=.: unary operator expected
make[1]: Leaving directory `/builddir/build/BUILD/kyua-atf-compat-0.1'
make[1]: *** [check-local] Error 2
make: *** [check-am] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.jKfzla (%check)
    Bad exit status from /var/tmp/rpm-tmp.jKfzla (%check)
RPM build errors:
Child return code was: 1
EXCEPTION: Command failed. See logs for output.

Comment 5 Julio Merino 2013-12-28 05:55:20 UTC
Apologies for the multi-month delay in getting back to this.

The problem in the previous spec file is that it was missing a Requires stanza.  Somehow I assumed that Requires would translate to also BuildRequires (as they do in the other packaging system I'm involved with) but they don't...

Here is a new copy of these files: requires are now complete and this is now for version 0.2 of the upstream code.  (Koji builds are awaiting for an update of kyua-cli to be pushed to stable.)

Spec URL: ftp://ftp.NetBSD.org/pub/NetBSD/misc/jmmv/kyua-atf-compat/kyua-atf-compat.spec
SRPM URL: ftp://ftp.NetBSD.org/pub/NetBSD/misc/jmmv/kyua-atf-compat/kyua-atf-compat-0.2-1.fc20.src.rpm

Comment 6 Julio Merino 2013-12-29 12:36:13 UTC
Validated that a koji f20 scratch build is now happy with the updated files above and the recent updates of kyua-cli pushed to f20.


Note You need to log in before you can comment on or make changes to this bug.