Red Hat Bugzilla – Bug 839119
Review Request: albatross - Desktop Suite for Xfce, GTK+ 2 and 3
Last modified: 2012-07-23 16:25:46 EDT
Spec URL: http://jaysonr.fedorapeople.org/packages/albatross/albatross.spec
SRPM URL: http://jaysonr.fedorapeople.org/packages/albatross/Albatross-1.2-4.fc17.src.rpm
Description: Albatross is a theme for GTK2/3 and xfwm4/metacity. The Albatross GTK theme is designed upon the Alvaro theme, from James Schriver. Albatross is designed to be smooth: no rough borders, no contrasted edges, no violent contrasts, a soft blue colour. Albatross currently uses a slightly modified version of Xfwm4.6′s default window decorations, made by Olivier Fourdan.
Fedora Account System Username: jaysonr
I am a new packager and I need a sponsor.
Here is a link to the successful koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4232573
I just caught an error I made in the .spec resulting in capitalized names...
I've updated the spec, srpm and re-ran my koji scratch build. They can be found below:
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4235326
First issue off hand:
[dan@Fedora17 SPECS]$ rpmlint bluebird.specbluebird.spec: W: invalid-url Source0: shimmerproject-Bluebird-v0.6-1-g5aa322d.tar.gz0 packages and 1 specfiles checked; 0 errors, 1 warnings.[dan@Fedora17 SPECS]$
Also please upload a .tar.gz to your fedora people site (not required but i'd appreciate it.)
Dan, here is the .spec from an approved package of another of the Shimmer themes I used as my basis: http://athmane.fedorapeople.org/pkgs/greybird.spec
It gives the same warning with rpmlint.
Can you help me understand what that means, and how I should fix it?
There's no real nice way to handle github source urls currently, so this rpmlint warning can be ignored for now. ;(
Look for a review here in a while.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2+ or CC-BY-SA)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream sha256sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
1. There's a bit of Release confusion going on.
but the changelog has:
* Tue Jul 10 2012 Jayson Rowe <email@example.com> 1.2-6
I'd suggest both should be 1 initally, then 2, etc.
So, if you could fix the above changelog entry to be 1.2-1,
then add a new 1.2-2 for the changes from this review, that would be great.
2. rpmlint says:
Can be ignored:
albatross.src: W: spelling-error %description -l en_US metacity -> meta city, meta-city, mendacity
albatross.src: W: spelling-error %description -l en_US colour -> color, co lour, co-lour
Can you trim the description down some:
albatross.src: E: description-line-too-long C Albatross is a theme for GTK2/3 and xfwm4/metacity. The Albatross GTK theme is designed upon the Alvaro theme, from James Schriver. Albatross is designed to be smooth: no rough borders, no contrasted edges, no violent contrasts, a soft blue colour. Albatross currently uses a slightly modified version of Xfwm4.6′s default window decorations, made by Olivier Fourdan.
As mentioned, this one can be ignored:
albatross.src: W: invalid-url Source0: shimmerproject-Albatross-v1.2-6-g6fead95.tar.gz
5 packages and 0 specfiles checked; 1 errors, 3 warnings.
New SPEC: http://jaysonr.fedorapeople.org/packages/albatross/albatross.spec
New SRPM: http://jaysonr.fedorapeople.org/packages/albatross/albatross-1.2-2.fc17.src.rpm
New Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4237534
Those changes look good, I see no further blockers, so this package is APPROVED.
New Package SCM Request
Package Name: albatross
Short Description: Desktop Suite for Xfce, GTK+ 2 and 3
Branches: f16 f17
SCM and summary package names don't match, please correct.
I'm not entirely sure what you mean. What should I change? (I am a new packager).
I think I figured it out.
Git done (by process-git-requests).
Caught a versioning issue with the Unico theme engine - fixed, and updated files here:
albatross-1.2-3.fc17 has been submitted as an update for Fedora 17.
albatross-1.2-3.fc16 has been submitted as an update for Fedora 16.
albatross-1.2-3.fc17 has been pushed to the Fedora 17 testing repository.
albatross-1.2-3.fc17 has been pushed to the Fedora 17 stable repository.
albatross-1.2-3.fc16 has been pushed to the Fedora 16 stable repository.