Spec URL: http://sgallagh.fedorapeople.org/packagereview/python-django-evolution/python-django-evolution.spec SRPM URL: http://sgallagh.fedorapeople.org/packagereview/python-django-evolution/python-django-evolution-0.6.7-2.fc18.src.rpm Description: When you run ./manage.py syncdb, Django will look for any new models that have been defined, and add a database table to represent those new models. However, if you make a change to an existing model, ./manage.py syncdb will not make any changes to the database. This is where Django Evolution fits in. Django Evolution is an extension to Django that allows you to track changes in your models over time, and to update the database to reflect those changes. Fedora Account System Username: sgallagh
Scratch-built in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4233568
I'll take this for a review.
- According to [1], the obsoletes shouldn't use macros, but rather hardcode the version from where you renamed the package. E.g. you should have "Obsoletes: django-evolution < 0.6.7-2". - "%defattr(-,root,root,-)" is not needed in the %files section, unless you want to build for EPEL 5 (which presumably you don't). Same applies for the BuildRoot tag, %clean section and "rm -rf $RPM_BUILD_ROOT". - You should delete the bundled egg-info directory in the %prep section (rm -rf django_evolution.egg-info), so that it gets regenerated during %build. These are not serious issues, so once you fix them, I will approve the package. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
New version with corrections: Spec URL: http://sgallagh.fedorapeople.org/packagereview/python-django-evolution/python-django-evolution.spec SRPM URL: http://sgallagh.fedorapeople.org/packagereview/python-django-evolution/python-django-evolution-0.6.7-3.fc18.src.rpm Note, this does not scratch-build in Rawhide at the moment due to a bad openssl build currently in the BuildRoot.
One more fix: You correctly hardcoded the obsoleted version, but the version you Provide should use the macros. E.g, you should have: Provides: django-evolution = %{name}-%{release} Obsoletes: django-evolution < 0.6.7-3 I don't have any more comments. Please fix this one before importing and don't forget to properly deprecate django-evolution from rawhide. Thanks! This package is APPROVED.
New Package SCM Request ======================= Package Name: python-django-evolution Short Description: Schema evolution for Django Owners: sgallagh Branches: InitialCC: sgallagh
Git done (by process-git-requests).
Package Change Request ====================== Package Name: python-django-evolution New Branches: el6 Owners: sgallagh, diegobz InitialCC: Migrating from django-evolution to python-django-evolution on EL6 to make maintenance simpler.