Spec URL: http://v3.sk/~hexo/rpm/colored.spec SRPM URL: http://v3.sk/~hexo/rpm/rubygem-colored-1.2-1.fc17.src.rpm Description: >> puts "this is red".red >> puts "this is red with a blue background (read: ugly)".red_on_blue >> puts "this is red with an underline".red.underline >> puts "this is really bold and really blue".bold.blue >> logger.debug "hey this is broken!".red_on_yellow # in rails >> puts Color.red "This is red" # but this part is mostly untested Fedora Account System Username: mzatko
Doesn't build in mock, rubygem-yars is missing in buildRequires ( that, or remove the file from %files )
Thanks for your review, I've updated spec, so Spec URL: http://v3.sk/~hexo/rpm/colored.spec SRPM URL: http://v3.sk/~hexo/rpm/rubygem-colored-1.2-2.fc17.src.rpm Description: >> puts "this is red".red >> puts "this is red with a blue background (read: ugly)".red_on_blue >> puts "this is red with an underline".red.underline >> puts "this is really bold and really blue".bold.blue >> logger.debug "hey this is broken!".red_on_yellow # in rails >> puts Color.red "This is red" # but this part is mostly untested Fedora Account System Username: mzatko
Maros some comments: * Please change the summary / description to be in accordance to packaging guidelines http://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description Since there is almost no documentation / comments we can draw upon, we can probably just use something similar to the following for both: "Rubygem extending the ruby string class to include methods that generates colored terminal output" * Why do you exclude %{gem_cache}? * Please move %{gem_instdir}/test/colored_test.rb into the doc subpackage * Since the yardoc dir is only created if rubygem-yard is present you should remove that reference from the specfile all together and rebuild the srpm w/out yard present on your system Thanks
Updated Spec URL: http://v3.sk/~hexo/rpm/rubygem-colored.spec SRPM URL: http://v3.sk/~hexo/rpm/rubygem-colored-1.2-3.fc17.src.rpm Description: Rubygem extending the ruby string class to include methods that generates colored terminal output. Fedora Account System Username: mzatko
Everything looks good, APPROVED.
New Package SCM Request ======================= Package Name: rubygem-temple Short Description: Extends ruby string class in order to colorize terminal output Owners: mzatko Branches: f17 f18 InitialCC:
WARNING: Requested package name rubygem-temple doesn't match bug summary rubygem-colored
New Package SCM Request ======================= Package Name: rubygem-colored Short Description: Extends ruby string class in order to colorize terminal output Owners: mzatko Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
rubygem-colored-1.2-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-colored-1.2-4.fc18
rubygem-colored-1.2-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-colored-1.2-4.fc17
rubygem-colored-1.2-4.fc18 has been pushed to the Fedora 18 testing repository.
rubygem-colored-1.2-4.fc17 has been pushed to the Fedora 17 stable repository.
rubygem-colored-1.2-4.fc18 has been pushed to the Fedora 18 stable repository.