Bug 839751 - Review Request: perl-Rose-DB - DBI wrapper and abstraction layer
Review Request: perl-Rose-DB - DBI wrapper and abstraction layer
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Jitka Plesnikova
Fedora Extras Quality Assurance
Depends On: 839701 839706 839742 839744
Blocks: 839754
  Show dependency treegraph
Reported: 2012-07-12 13:51 EDT by Bill Pemberton
Modified: 2014-12-23 03:04 EST (History)
4 users (show)

See Also:
Fixed In Version: perl-Rose-DB-0.775-2.el7
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-08-21 05:47:21 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jplesnik: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Bill Pemberton 2012-07-12 13:51:49 EDT
Spec URL: http://wfp.fedorapeople.org/perl-Rose-DB.spec
SRPM URL: http://wfp.fedorapeople.org/perl-Rose-DB-0.769-3.fc17.src.rpm

Rose::DB is a wrapper and abstraction layer for DBI-related functionality.
A Rose::DB object "has a" DBI object; it is not a subclass of DBI.

This requires Rose::Object, SQL::ReservedWords, and Time::Clock

Fedora Account System Username: wfp
Comment 2 Jitka Plesnikova 2012-07-30 09:16:44 EDT
Package Review

- = N/A
x = Pass
! = Fail 
? = Not evaluated

==== Generic ====
[x]: EXTRA Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[-]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[-]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[!]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
[x]: SHOULD SourceX tarball generation or download is documented.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
[x]: SHOULD Spec use %global instead of %define.

* Add to buildrequires:
  perl(Test::Pod) >= 1.00 - ./t/pod.t:7
  perl(Carp) - ./lib/Rose/DB/Registry.pm:5
  perl(DateTime::Infinite) - ./lib/Rose/DB/Pg.pm:5
  perl(Exporter) - ./lib/Rose/DB/Constants.pm:5
* Please add version to buildrequires and requires. The versions are mentioned in META.yml
  perl(Bit::Vector::Overload) 6.4
  perl(DateTime::Format::Pg) >= 0.11
  perl(Rose::DateTime::Util) >= 0.532
  perl(Rose::Object) >= 0.854
* The filter of requires should be removed. It is not needed.

The package was successfully built in rawhide.
Please update the spec file before submit.


Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
Comment 3 Bill Pemberton 2012-07-30 10:09:31 EDT
New Package SCM Request
Package Name: perl-Rose-DB
Short Description: DBI wrapper and abstraction layer
Owners: wfp
Branches: f16 f17 el6
InitialCC: perl-sig
Comment 4 Gwyn Ciesla 2012-07-30 10:33:16 EDT
Git done (by process-git-requests).
Comment 5 Fedora Update System 2012-08-09 14:59:15 EDT
perl-Rose-DB-0.769-5.fc16 has been submitted as an update for Fedora 16.
Comment 6 Fedora Update System 2012-08-09 15:10:04 EDT
perl-Rose-DB-0.769-5.fc17 has been submitted as an update for Fedora 17.
Comment 7 Fedora Update System 2012-08-10 18:33:14 EDT
perl-Rose-DB-0.769-5.fc17 has been pushed to the Fedora 17 testing repository.
Comment 8 Fedora Update System 2012-08-21 05:47:21 EDT
perl-Rose-DB-0.769-5.fc17 has been pushed to the Fedora 17 stable repository.
Comment 9 Fedora Update System 2012-08-21 05:55:36 EDT
perl-Rose-DB-0.769-5.fc16 has been pushed to the Fedora 16 stable repository.
Comment 10 Fedora Update System 2014-12-05 09:51:59 EST
perl-Rose-DB-0.775-2.el7 has been submitted as an update for Fedora EPEL 7.
Comment 11 Fedora Update System 2014-12-23 03:04:50 EST
perl-Rose-DB-0.775-2.el7 has been pushed to the Fedora EPEL 7 stable repository.

Note You need to log in before you can comment on or make changes to this bug.