Spec URL: http://10.34.2.200/icedtea-web-dailyreport/ant17/conflicts-v2/rhel-5-x86_64/ant17.spec SRPM URL: http://10.34.2.200/icedtea-web-dailyreport/ant17/conflicts-v2/rhel-5-x86_64/ant17-1.7.1-2jpp.0.src.rpm Description: https://bugzilla.redhat.com/show_bug.cgi?id=803797
Some more info: http://post-office.corp.redhat.com/archives/java-maint/2012-July/author.html Update ant to 1.7 or provide package ant7 for rhel5.x
All good from the installer side of things, no changes needed in anaconda.
From a package review point of view, this looks mostly-good. There's a couple nits I'll point out, minor cleanup really. There are two defines: %define name16 ant %define name_legacy ant Do we really need for these to be separate? What is the meaning of "legacy" vs "16". Can we get away with just one of these? It looks to me like both are used, but pretty much as synonyms. The summary: Summary: %{name17} build tool for java in version 1.7 Summary(it): Tool per la compilazione di programmi java Summary(fr): Outil de compilation pour java Seems redundant to include the name in the summary, and the wording seems awkward. Can I suggest: "Build tool for Java supporting version 1.7" (for bonus points, it might be nice to mention 1.7 in the translated versions too) Please take care of these tiny things before building the package. Otherwise, good to go.
Thank you. Considering as approved then. Before push I will fix summary (and remove translations then) and make an cleanup. name16 versus name_legacy - they are then same just by coincidence, and is more then possible that name16 will be changed. Strictly said - they are pointing to completely different product. Thank you very much for review.