Description of problem: when we create a snapshot, the create snpashot dialogue does not close until each disk snapshot is sent to vdsm. if we have a vm with several disks the dialogue remains open until we send each disk's task to vdsm this is highly visible and gives impression that there is something wrong. Version-Release number of selected component (if applicable): si10 How reproducible: 100% Steps to Reproduce: 1. create a vm with 6-7 disks and create a snapshot 2. 3. Actual results: create disks dialogue will not be closed until tasks have been created and sent to vdsm by backend. Expected results: we should close dialogue and fail with CanDoAction if needed. Additional info:
(In reply to comment #0) > Expected results: > > we should close dialogue and fail with CanDoAction if needed. > > Additional info: The implication of that means that a user will not get notified that the initiation of the clone has failed, it will only be visible in the event log. It will also require two level of async task management, one GUI to BE, and then BE to VDSM. Currently as I recall there is only the later. Not sure this is the right solution. Indeed if the snapshot creation itself fails on VDSM, then again it will only show in the even log, but this is unavoidable since the actual snapshot creation is far longer then just sending the task (especially when live snapshot are involved). The solution may be either a better indication that the task is still being created or sending those tasks concurrently to VDSM and not sequentially.
assuming most of the delay is in the "Execute" part of the command rather than the "CanDoAction" part, the call to RunAction can change to RunMultipleAction (so the "Execute" part will run asynchronously, hence the GUI "delay" will be shorter)
Change-Id: I12a0b708e61d21b2a6276620d7350e626eb12fd8
checked on si13.2 the dialogue is still not closing until all CreateSnapshotVDSCommand for each of the disks is run. moving back to devel.
indeed - seems that patch hasn't been cherry-picked downstream.
verified on si15