I've been playing with git-review. It's a very useful tool, and I would love to see it in EPEL6. I have done a scratch-build and verified that it builds, and the resulting RPM works just fine on RHEL6:
I've noticed one thing that should be addressed in the EPEL6 branch. Git-review requires argparse.py, which is part of python-libs in F17 but is in a separate package 'python-argparse' for RHEL6. For the EPEL6 branch there should probably be an explicit Requires for python-argparse, as this dependency wasn't discovered automatically during build.
This is weird, I threw it into Koji and it worked without any changes
to Require: python-argparse.
Requires are evaluated on installing the package.
So when installing , python-argparse won't be installed and when it's not installed "by accident" git-review will fail, when it tries to import it.
An interesting question is why Koji doesn't automatically detect the argparse requirement. Perhaps it's because 'import argparse' is inside main().
I don't know the current state of this, but someone wanted to work on this:
AFAIK, there are still no automatic provides/requires yet.
I see. The result is a package that builds and installs but fails with
"ImportError: No module named argparse".
Hopefuly git-review-1.17-2.el6 works better.
(looks like I build 1.17-2.el6 which is not at all the same as 1.17-2.fc17)
Thanks Pete. Tested git-review-1.17-2.el6 and confirmed that it works. Also, python-argparse was correctly pulled in as dependency.
git-review-1.17-2.el6 has been submitted as an update for Fedora EPEL 6.
git-review-1.17-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
git-review-1.17-2.el6 has been pushed to the Fedora EPEL 6 stable repository.