Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-monolog.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-monolog-1.1.0-1.fc17.src.rpm Description: Logging for PHP 5.3. Fedora Account System Username: siwinski
Some questions: why do you package 1.1.0 when latest tagged version is 1.2.1 ? (probably tagged after this review was submitted) Summary: "PHP 5.3" ? seems to reduce usage, even if from upstream, could probably be improved %description : should probably be improved (from README ?) Probably a comment about optional dep which need to be installed for various handler (amqp, swiftmailer, gelf, mongo, ...) License is MIT, according to upstream
Updated to upstream version 1.2.1 + several fixes SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-Monolog.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-Monolog-1.2.1-1.fc17.src.rpm
Created attachment 646835 [details] php-Monolog-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 842199
All seems ok. === APPROVED ===
New Package SCM Request ======================= Package Name: php-Monolog Short Description: Logging for PHP 5.3 Owners: siwinski Branches: f17 f18 el6 InitialCC:
Git done (by process-git-requests).
php-Monolog-1.2.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-Monolog-1.2.1-1.el6
php-Monolog-1.2.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-Monolog-1.2.1-1.fc18
php-Monolog-1.2.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-Monolog-1.2.1-1.fc17
php-Monolog-1.2.1-1.fc18 has been pushed to the Fedora 18 testing repository.
php-Monolog-1.2.1-1.fc18 has been pushed to the Fedora 18 stable repository.
php-Monolog-1.2.1-1.fc17 has been pushed to the Fedora 17 stable repository.
php-Monolog-1.2.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.