RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 842272 - include-passwd option can't worked when using domdisplay.
Summary: include-passwd option can't worked when using domdisplay.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Martin Kletzander
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-07-23 10:06 UTC by zhe peng
Modified: 2013-02-21 07:19 UTC (History)
8 users (show)

Fixed In Version: libvirt-0.10.0-0rc0.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-21 07:19:30 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:0276 0 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2013-02-20 21:18:26 UTC

Description zhe peng 2012-07-23 10:06:03 UTC
Description of problem:
--include-passwd option can't worked when using domdisplay

Version-Release number of selected component (if applicable):
libvirt-0.9.13-3.el6.x86_64

How reproducible:
always

Steps to Reproduce:
Steps to Reproduce:
1. prepare a guest with spice graphic
2. setup spice ssl env.
3. give a password to spice
#virsh dumpxml $guest --security-info
  ......
   <graphics type='spice' port='5900' tlsPort='5907' autoport='yes' listen='0.0.0.0' keymap='en-us' passwd='redhat' passwdValidTo='2022-02-27T19:46:10' connected='disconnect'>
      <listen type='address' address='0.0.0.0'/>
      <channel name='main' mode='secure'/>
      <channel name='inputs' mode='secure'/>
    </graphics>
  ......
4. use virt-viewer to connect guest
# remote-viewer spice://$IP?port=5900\&tls-port=5907 --spice-host-subject="C=IL,L=Raanana,O=Red Hat,CN=my server" --spice-ca-file='/etc/pki/libvirt-spice/ca-cert.pem'
worked well with input correct password
5. using domdisplay to show spice URI
# virsh domdisplay $guest --include-password


Actual results:
spice://localhost?port=5900&tls-port=5907
no password shown up in URI.

Expect result:

should providing the password for the SPICE channel.



additional :
i check the patch,
virAsprintf(&xpath, "string(/domain/devices/graphics"
                     "[ type='%s']/@passwd)", scheme[iter]);

maybe should be:
virAsprintf(&xpath, "string(/domain/devices/graphics[ type='%s']"
                     "/@passwd)", scheme[iter]);

Comment 2 Martin Kletzander 2012-07-23 18:58:40 UTC
Patches has been posted upstream:

https://www.redhat.com/archives/libvir-list/2012-July/msg01235.html

Comment 3 Martin Kletzander 2012-07-25 09:09:02 UTC
Patches have been commited upstream, moving to POST:

commit 8101d434336a2ad89f6d2dbfbff54f79b3eb6890
Author: Martin Kletzander <mkletzan>
Date:   Tue Jul 24 16:00:14 2012 +0200

    virsh: fixed domdisplay command

Comment 7 zhpeng 2012-08-07 01:56:13 UTC
I'm sorry for that i made a mistake...

test it with libvirt-0.10.0-0rc0.el6:

virsh # domdisplay rhel63q
spice://localhost?port=5900&tls-port=5901
virsh # domdisplay rhel63q --include-password 
spice://localhost?port=5900&tls-port=5901&password=redhat

So this is verified.

Comment 8 errata-xmlrpc 2013-02-21 07:19:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html


Note You need to log in before you can comment on or make changes to this bug.