Bug 842328 - Review Request: rubygem-jquery-rails - Use jQuery with Rails 3
Review Request: rubygem-jquery-rails - Use jQuery with Rails 3
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Vít Ondruch
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-23 09:46 EDT by Bohuslav "Slavek" Kabrda
Modified: 2012-07-24 10:10 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-07-24 10:10:35 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
vondruch: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Bohuslav "Slavek" Kabrda 2012-07-23 09:46:15 EDT
Spec URL: http://bkabrda.fedorapeople.org/pkgs/jquery-rails/rubygem-jquery-rails.spec
SRPM URL: http://bkabrda.fedorapeople.org/pkgs/jquery-rails/rubygem-jquery-rails-2.0.2-1.fc17.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4323052
Description: This gem provides jQuery and the jQuery-ujs driver for your Rails 3 application.
Fedora Account System Username: bkabrda
Comment 1 Vít Ondruch 2012-07-24 07:54:25 EDT
I'll take it for a review.
Comment 2 Vít Ondruch 2012-07-24 08:08:31 EDT
* More specific license
  - Although it seems that the license field is correct, could you please
    elaborate a bit more what license is for what library?

* Smoke test failed?
  - I did just small smoketest and it failed. I believe that it depends on
    Rails application configuration, but anyway, could you please doublecheck?

$ irb
reqirb(main):001:0> require 'jquery-rails'
NameError: uninitialized constant Rails
	from /usr/share/gems/gems/jquery-rails-2.0.2/lib/jquery/rails/engine.rb:1:in `<top (required)>'
	from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
	from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
	from /usr/share/gems/gems/jquery-rails-2.0.2/lib/jquery/rails.rb:1:in `<top (required)>'
	from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
	from /usr/share/rubygems/rubygems/custom_require.rb:36:in `require'
	from /usr/share/gems/gems/jquery-rails-2.0.2/lib/jquery-rails.rb:1:in `<top (required)>'
	from /usr/share/rubygems/rubygems/custom_require.rb:60:in `require'
	from /usr/share/rubygems/rubygems/custom_require.rb:60:in `rescue in require'
	from /usr/share/rubygems/rubygems/custom_require.rb:35:in `require'
	from (irb):1
	from /usr/bin/irb:12:in `<main>'

Otherwise I see no issue => APPROVED. But please, make sure that you understand the above mentioned error and better describe the licenses before import.
Comment 3 Bohuslav "Slavek" Kabrda 2012-07-24 09:27:32 EDT
Thanks for the review!
Yes, I'll be more verbose about the licenses.
jquery-rails depends on rails being required before, which is what is done using bundler. This is the expected behaviour, but good catch anyway :)

New Package SCM Request
=======================
Package Name: rubygem-jquery-rails
Short Description: Use jQuery with Rails 3
Owners: bkabrda
Branches: 
InitialCC:
Comment 4 Gwyn Ciesla 2012-07-24 09:32:21 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.