Spec URL: http://ankursinha.fedorapeople.org/python-django-authopenid/python-django-authopenid.spec SRPM URL: http://ankursinha.fedorapeople.org/python-django-authopenid/python-django-authopenid-1.0.1-1.fc18.src.rpm Description: Django authentication application with openid using django auth contrib. This application allows a user to connect to you website with a legacy account (user name/password) or an openid URL. Fedora Account System Username: ankursinha +++ Rpmlint output when run on mock output and spec: [ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm python-django-authopenid-1.0.1-1.fc17.src.rpm ../SPECS/python-django-authopenid.spec python-django-authopenid.noarch: W: spelling-error Summary(en_US) Openid -> Opined, Opened, Open id python-django-authopenid.noarch: W: spelling-error %description -l en_US openid -> opined, opened, open id python-django-authopenid.noarch: W: spelling-error %description -l en_US auth -> auto, Ruth, author python-django-authopenid.noarch: W: spelling-error %description -l en_US contrib -> cont rib, cont-rib, contribute python-django-authopenid.noarch: W: self-obsoletion django-authopenid < 1.0.1-4 obsoletes django-authopenid = 1.0.1-1.fc18 python-django-authopenid.src: W: spelling-error Summary(en_US) Openid -> Opined, Opened, Open id python-django-authopenid.src: W: spelling-error %description -l en_US openid -> opined, opened, open id python-django-authopenid.src: W: spelling-error %description -l en_US auth -> auto, Ruth, author python-django-authopenid.src: W: spelling-error %description -l en_US contrib -> cont rib, cont-rib, contribute python-django-authopenid.src: W: spelling-error Summary(en_US) Openid -> Opined, Opened, Open id python-django-authopenid.src: W: spelling-error %description -l en_US openid -> opined, opened, open id python-django-authopenid.src: W: spelling-error %description -l en_US auth -> auto, Ruth, author python-django-authopenid.src: W: spelling-error %description -l en_US contrib -> cont rib, cont-rib, contribute 3 packages and 1 specfiles checked; 0 errors, 13 warnings. [ankur@ankur SRPMS]$
I'll take this for a review.
- Probably just a typo: Your VR is 1.0.1-1, but you obsolete django-authopenid < 1.0.1-4. That should be 1.0.1-1, right? - You should remove the egg-info directory in the %prep section, so that it gets recreated by python setup.py build. Otherwise the package looks good, so once you correct these nits, I will approve it.
(In reply to comment #2) > - Probably just a typo: Your VR is 1.0.1-1, but you obsolete > django-authopenid < 1.0.1-4. That should be 1.0.1-1, right? Hey Bohuslav, Not sure about this: The django-authopenid package (that I'm renaming to python-django-authopenid) had a current running package VR of 1.0.1-3. According to the example here[1], the obsolete is correct: python-django-authopeind-1.0.1-2 (latest spec) obsoletes django-authopenid < 1.0.1-4 (so, 1.0.1-{1,2,3}) The comment in the example says: "# Obsolete anything that is lower than the _bumped release_ of the renamed package. Obsolete with hardcoded values of renamed package" Do have a look and let me know? I'll make the change if required, it's really a tiny one. > - You should remove the egg-info directory in the %prep section, so that it > gets recreated by python setup.py build. Done. > > Otherwise the package looks good, so once you correct these nits, I will > approve it. New spec/srpm: http://ankursinha.fedorapeople.org/python-django-authopenid/python-django-authopenid.spec http://ankursinha.fedorapeople.org/python-django-authopenid/python-django-authopenid-1.0.1-2.fc17.src.rpm * Wed Jul 25 2012 Ankur Sinha <ankursinha AT fedoraproject DOT org> 1.0.1-2 - Remove egg-info to ensure that setup.py builds it #842633 [1] https://fedoraproject.org/wiki/User:Bkabrda/Django_rename#django-bar Thanks, Ankur
Yes, that thing on my page is not clear enough - the initial release of python-django-authopenid package should have already been 4, because the release of obsoleted package was 3, see [1]. So please bump your release to 4 before commiting to dist-git :) And don't forget to retire django-authopenid properly. Thanks! [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages This package is APPROVED.
(In reply to comment #4) > Yes, that thing on my page is not clear enough - the initial release of > python-django-authopenid package should have already been 4, because the > release of obsoleted package was 3, see [1]. > So please bump your release to 4 before commiting to dist-git :) And don't > forget to retire django-authopenid properly. Thanks! Ah. Done: http://ankursinha.fedorapeople.org/python-django-authopenid/python-django-authopenid-1.0.1-4.fc17.src.rpm http://ankursinha.fedorapeople.org/python-django-authopenid/python-django-authopenid.spec > > [1] > http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming. > 2FReplacing_Existing_Packages > > This package is APPROVED. Thanks for the quick review Bohuslav :)
New Package SCM Request ======================= Package Name: python-django-authopenid Short Description: OpenID authentication application for Django Owners: ankursinha Branches: f16 f17 InitialCC:
Git done (by process-git-requests).
python-django-authopenid-1.0.1-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-django-authopenid-1.0.1-4.fc16
python-django-authopenid-1.0.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-django-authopenid-1.0.1-4.fc17
python-django-authopenid-1.0.1-4.fc16 has been pushed to the Fedora 16 testing repository.
Closing this bug, since the package has been successfully renamed and the old one has been deprecated properly.
python-django-authopenid-1.0.1-4.fc17 has been pushed to the Fedora 17 stable repository.
python-django-authopenid-1.0.1-4.fc16 has been pushed to the Fedora 16 stable repository.