Bug 84266 - dns boot command line info not used fully (and a fix?)
Summary: dns boot command line info not used fully (and a fix?)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: anaconda
Version: 9
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jeremy Katz
QA Contact: Mike McLean
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-02-13 20:14 UTC by Matthew Miller
Modified: 2008-01-17 17:49 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2003-05-25 14:50:36 UTC


Attachments (Terms of Use)

Description Matthew Miller 2003-02-13 20:14:56 UTC
If one specifies "dns" on the command line, this makes it into the second-stage
installer, but isn't shown in the *first* stage (in the loader) if one is doing
a network install. The culprit seems to be at the beginning of 
setupNetworkDeviceConfig in net.c -- if loaderData->ipinfo_set is 0, the
function returns right away. This check seems unnecessary, as the individual
bits of data each get their own if statement later -- and removing it makes
everything work perfectly, as far as I can tell.

Comment 1 Jeremy Katz 2003-02-13 22:37:54 UTC
Are you specifying your ip on the command line?  Essentially, to get any of the
network information to take effect, you need to specify the ip as well otherwise
we throw it out as invalid.

Comment 2 Matthew Miller 2003-02-13 22:49:21 UTC
No, I'm not. And I don't want to. :) In fact, perhaps this bug should be changed
to: "Don't throw out dns information from the command line just because ip isn't
set". :)

Most people setting up machines here don't know the campus DNS servers off the
top of their heads, so it's extremely useful to have the information pre-filled.
With earlier versions, I patched anaconda to have them hardcoded, but that's
both a pain and ugly. So I want to specify them on the command line in 
isolinux.cfg  -- a much more trivial change to make since all it requires is a
text editor and mkisofs.

Ideally, I'd like to be able to specify three different dns servers this way,
but I figure one thing at a time. :)

Comment 3 Matthew Miller 2003-02-16 03:02:16 UTC
(I created bug #84409 for the "specify multiple servers" thing, by the way.)

Comment 4 Jeremy Katz 2003-02-17 20:30:03 UTC
Okay, I guess that's good enough reasoning to convince me.  Committed something
similar to CVS

Comment 5 Matthew Miller 2003-02-19 14:21:12 UTC
ipinfo_set now seems to be set in multiple places but never actually read 
(except in printLoaderDataIPINFO). Given your comment in loader.h about how you 
don't like the _set attribs, should it be completely removed?

Comment 6 Brent Fox 2003-05-25 14:50:36 UTC
I'm going through Bugzilla closing some bugs that have been marked as Modified
for some period of time.  I believe that most of these issues have been fixed,
so I'm resolving these bugs as Rawhide.  If the bug you are seeing still exists,
please reopen this report and mark it as Reopened.


Note You need to log in before you can comment on or make changes to this bug.