Bug 843103 - remote-viewer fails to start when --full-screen or -f precedes spice:// uri
remote-viewer fails to start when --full-screen or -f precedes spice:// uri
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: virt-viewer (Show other bugs)
Unspecified Unspecified
low Severity low
: beta
: 6.4
Assigned To: Marc-Andre Lureau
Virtualization Bugs
Depends On:
Blocks: 845645 977237
  Show dependency treegraph
Reported: 2012-07-25 11:28 EDT by David Jaša
Modified: 2013-11-21 03:01 EST (History)
15 users (show)

See Also:
Fixed In Version: virt-viewer-0.5.6-1.el6
Doc Type: Enhancement
Doc Text:
no doc required
Story Points: ---
Clone Of:
: 977237 (view as bug list)
Last Closed: 2013-11-21 03:01:06 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description David Jaša 2012-07-25 11:28:08 EDT
Description of problem:
remote-viewer fails to start when --full-screen or -f precedes spice:// uri

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. run:
remote-viewer <other_options> -f spice://host:port
remote-viewer <other_options> --full-screen spice://host:port

Actual results:
remote-viewer fails to start with error:
Invalid full-screen argument: spice://

Expected results:
remote-viewer starts in full-screen

Additional info:
the bug occurs only when the --full-screen/-f option is followed by spice:// uri right away. When any other option is put between -f and uri or the -f is after the uri, the bug is not triggered.
Comment 1 Christophe Fergeau 2012-08-10 08:34:13 EDT
This happens because -f/--full-screen takes an optional 'autoconf' argument, so if -f is followed by a non-parameter string (ie one not starting with -), it expects it to be 'autoconf', and fails if it's something else (for example spice://yyyy).
I don't see an easy way to handle both the optional argument, and the '-f spice://yyyy" case using the GOption API :-/ For what it's worth, 'remote-viewer -f -- spice://yyyy' works
Comment 5 Marc-Andre Lureau 2013-05-08 09:23:47 EDT
imho, comment #1 is the right solution. should we close that bug?
Comment 6 David Jaša 2013-05-09 09:41:09 EDT
Please add the "-f --" hint to --help output / man page.
Comment 7 Marc-Andre Lureau 2013-05-09 10:08:17 EDT
(In reply to comment #6)
> Please add the "-f --" hint to --help output / man page.

sent patch to ML:
Comment 14 tingting zheng 2013-07-04 01:51:51 EDT
I can reproduce this issue with:

# remote-viewer -f spice://localhost:5901
Invalid full-screen argument: spice://localhost:5901
Run 'remote-viewer --help' to see a full list of available command line options

# man remote-viewer

       -f, --full-screen
           Start with the window maximised to fullscreen

Tested with:

# man remote-viewer
       -f, --full-screen=<auto-conf>
           Start with the windows maximized to fullscreen.

           If the argument ’auto-conf’ is given, the remote display will be reconfigured to match at
           best the client physical monitor configuration on initialization, by enabling or disabling
           extra monitors as necessary. This is currently implemented by the Spice backend only.

# remote-viewer --full-screen=auto-conf spice://localhost:5902

# remote-viewer -f -- spice://localhost:5902

The above 2 commands work well,so move the bug to VERIFIED.
Comment 15 errata-xmlrpc 2013-11-21 03:01:06 EST
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.