Red Hat Bugzilla – Bug 843324
snapshot-edit will report error message but return 0 when do not update xml
Last modified: 2013-10-20 17:45:36 EDT
Description of problem: snapshot-edit will report error message but return 0 when do not update xml error message and return 0 is not consistent Version-Release number of selected component (if applicable): libvirt-0.9.13-3.el6.x86_64 How reproducible: 100% Steps to Reproduce: 1. create a snapshot for domain #virsh snapshot-create-as q3 s1 Domain snapshot s1 created 2. run snapshot-edit but do not modify any info in the xml then quit it # virsh snapshot-edit q3 s1 Snapshot s1 XML configuration not changed. error: Failed to update s1 [root@intel-q9400-4-2 ~]# echo $? 0 Actual results: error message and return 0 is not consistent Expected results: no error message Additional info:
patch sent to upstream https://www.redhat.com/archives/libvir-list/2012-August/msg01559.html
commit 44574a8789c4e97b0cf4ec020aec1f3927572b3a Author: Guannan Ren <gren@redhat.com> Date: Wed Aug 22 04:37:34 2012 +0800 virsh: don't print error info when snapshot xml is not changed If xml is not changed, error message is printed. So check ret value instead of edit variable for error message.
the patch has been pushed into upstream git. but not go into libvirt-0.10.0-0rc1.el6, please test it with next version.
Verify this bug with: libvirt-0.10.0-1.el6.x86_64 # virsh snapshot-edit 63z 63z1 Snapshot 63z1 XML configuration not changed. [root@intel-q9400-4-2 rpms]# echo $? 0
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2013-0276.html