Red Hat Bugzilla – Bug 843591
rhevm-manage-domains should not execute rhevm-config via a process, but use the java code directly
Last modified: 2016-02-10 14:31:24 EST
Description of problem:
Exeucting the rhevm-config code from rhevm-manage-domains using a script as an intermediate layer is bad, due to the following reasons:
1. rhevm-manage-domains consumes the output stream (stdout) of engine-config - any change to prints (due to a change in log4j configuration, for instance) can break the behavior
2. Execution takes longer - bad user experience which can be improved.
Version-Release number of selected component (if applicable):
Always. This is how the code works now.
Steps to Reproduce:
No more usage of shell script , rhevm-manage domains should use the classes of engine-config directly.
Changing log4.xml (for example) of engine-config should not break the behavior of rhevm-manage-domains.
In reply to comment #2 and comment #3 -
You can say this is an improvement, however -
Solution architects might need to change log level of engine-config - if they do, this might break manage-domains.
Any other unexpected print - might break manage-domains.
This is a very shaky behavior.
Let's put it this way - if we don't expect solution architects to change the log4j configuration for engine-config, then I guess we can say that any other undeed print is due to bug in the engine-config code itself (so we will have to fix it anyway).
About when to intoduce this change - I didn't think at first it is important enough for this version, but after I saw how things are shaky - I decided we should take care of it ASAP.
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.