Red Hat Bugzilla – Bug 844008
git p4 support is disabled when NO_PYTHON is enabled
Last modified: 2013-01-10 06:03:21 EST
Description of problem:
After update of git python support was disabled.
Version-Release number of selected component (if applicable):
Run any git extension using python.
Steps to Reproduce:
1. Run any git extension using python.
git was built without support for ... (NO_PYTHON=1).
What git extensions are you trying to run? Setting NO_PYTHON was deliberate. The python bits in the git tree are only for foreign-scm-helper that is not done, as I understand it. That's why upstrem doesn't ship them in it's rpm packaging either.
Has that changed? Can you tell us why you want them to be included? Git has plenty of subpackages already. I'm not eager to add more, especially if upstream doesn't consider them ready.
git-p4 is written in python (I use local copy). It worked with the F16 & F17 default git and it have have broken with the update to 188.8.131.52 (it looks like NO_PYTHON did not worked before).
NO_PYTHON certainly worked previously (and is still working, just a bit too well perhaps :). The git-p4.py script was moved from contrib/fast-import to the toplevel of the git tree in 1.7.11. As part of that move, the installation replaces the git-p4 script with a shell script that outputs the error you received when NO_PYTHON is set. If you copy the git-p4.py script from the 184.108.40.206 tarball, it appears to function (at least it doesn't have any failed imports).
# This is a copy of the git-p4.py from 220.127.116.11
usage: /tmp/git-p4.py <command> [options]
valid commands: clone, rollback, debug, commit, rebase, branches, sync, submit
Try /tmp/git-p4.py <command> --help for command specific help.
# This is the output that the newly installed git-p4:
$ git p4
fatal: git was built without support for git-p4 (NO_PYTHON=1).
We'll have to work out whether we want to split that into a separate package or not. But it's not something that was officially supported before.
+1 for splitting it to a separate package. Thus far I've been using cludgy solutions for getting git-p4 to work on Fedora. Needless to say they all break with git gets updated on me. It'd be very nice to have this installable since I use the git p4 integration regularly.
I've got a scratch build that I think is in good shape. I'm going to update git to 18.104.22.168 and work on pushing that into rawhide/f18. This *may* get pushed down to f17 at some point, but I'm not sure. No promises.
The f17 scratch build is here:
git-22.214.171.124-1.fc18 has been submitted as an update for Fedora 18.
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing git-126.96.36.199-1.fc18'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
git-1.7.12-1.fc18 has been submitted as an update for Fedora 18.
git-1.7.12-2.fc18 has been submitted as an update for Fedora 18.
git-188.8.131.52-1.fc18 has been submitted as an update for Fedora 18.
git-184.108.40.206-1.fc17 has been submitted as an update for Fedora 17.
This is already fixed in git-220.127.116.11-1.fc17
(In reply to comment #12)
> This is already fixed in git-18.104.22.168-1.fc17
Ah, sorry, I meant git-1.8.0-1.fc18
The fix is not going to be backported to Fedora 17.