Spec URL: http://jplesnik.fedorapeople.org/perl-Fennec-Lite/perl-Fennec-Lite.spec SRPM URL: http://jplesnik.fedorapeople.org/perl-Fennec-Lite/perl-Fennec-Lite-0.004-1.fc18.src.rpm Description: Fennec does a ton, but it may be hard to adopt it all at once. It also is a large project, and has not yet been fully split into component projects. Fennec::Lite takes a minimalist approach to do for Fennec what Mouse does for Moose. Fedora Account System Username: jplesnik
I will review this package
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [-]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-]: MUST Package contains no bundled libraries. [-]: MUST Changelog in prescribed format. [-]: MUST Sources contain only permissible code or content. [-]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [-]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package contains desktop file if it is a GUI application. [-]: MUST Development files must be in a -devel package [-]: MUST Package requires other packages for directories it uses. [-]: MUST Package uses nothing in %doc for runtime. [-]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [-]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [-]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL5 is required [!]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [-]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX tarball generation or download is documented. [x]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0 (Fennec-Lite-0.004.tar.gz) [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Rpmlint ------- Checking: perl-Fennec-Lite-0.004-1.fc17.src.rpm perl-Fennec-Lite-0.004-1.fc17.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- perl-Fennec-Lite-0.004-1.fc17.noarch.rpm (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.14.2) perl(B) perl(Carp) perl(List::Util) perl(Test::Builder) perl(Test::More) perl(strict) perl(warnings) Provides -------- perl-Fennec-Lite-0.004-1.fc17.noarch.rpm: perl(Fennec::Lite) = 0.004 perl-Fennec-Lite = 0.004-1.fc17 MD5-sum check ------------- http://www.cpan.org/authors/id/E/EX/EXODIST/Fennec-Lite-0.004.tar.gz : CHECKSUM(SHA256) this package : dce28e3932762c2ff92aa52d90405c06e898e81cb7b164ccae8966ae77f1dcab CHECKSUM(SHA256) upstream package : dce28e3932762c2ff92aa52d90405c06e898e81cb7b164ccae8966ae77f1dcab
Issues: [!]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames [!]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. This is reflected in the files as well: Fennec-Lite-0.004/blib/lib/Fennec/Lite.pm: *No copyright* UNKNOWN Fennec-Lite-0.004/lib/Fennec/Lite.pm: *No copyright* UNKNOWN There's no license file included, and the README file states the following at the bottom: COPYRIGHT Copyright (C) 2010 Chad Granum Fennec-Lite is free software; Standard perl license. Fennec-Lite is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the license for more details. Apart from this the package is ok. How this should be dealt with?
Requirements are ok as well: $ rpm -qp --requires perl-Fennec-Lite-0.004-1.fc17.noarch.rpm | uniq -c 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(B) 1 perl(Carp) 1 perl(List::Util) 1 perl(Test::Builder) 1 perl(Test::More) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1
If the license check doesn't work properly for some licenses. It is usually better to check it manually in the module/LICENSE/README/... Standard perl license is "GPL+ or Artistics".
I'm taking your words of expertise that "Standard perl license" means "GPL+ or Artistic" and that the COPYRIGHT section at the end of the README file counts as the license file. btw, I assigned myself to the bug with fedora-review but the flag has been set by user "psabata". Package approved.
New Package SCM Request ======================= Package Name: perl-Fennec-Lite Short Description: Minimalist Fennec, the commonly used bits Owners: jplesnik mmaslano ppisar psabata Branches: InitialCC: perl-sig
Git done (by process-git-requests).
Thank you for the review and the repository.