Hide Forgot
Created attachment 601680 [details] Proposed patch to fix scriptlets for el5 and el6 Description of problem: scriptlets handles service whatsup when they should handle service whatsup-pingd - other logics is not quite correct either - package update will restart service instead of conditionally restarting it.
Thanks for the patch this is very reasonable patch and I'm including it. However, I was disappointed at my searching the fedora wiki to find documentation on how one should handle services in Fedora or EPEL 5/6. I'll get this in as soon as I get back from vacation.
These old scriptlets are over here: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Services http://fedoraproject.org/wiki/Packaging/SysVInitScript#InitscriptScriptlets Systemd: http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_addition_to_systemd_unit_files
whatsup-1.13-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/whatsup-1.13-4.el5
whatsup-1.13-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/whatsup-1.13-4.el6
I've looked over the scripts and they seem to fit more of the model the documentation posted suggests for all distros supported. If either of you would like to poke the karma of the package feel free to do so. Otherwise, I'll wait a couple of days maybe Monday or Tuesday to push it myself.
Hmmm, I was also disappointed that I couldn't find a web page with the scripts from the koji build.
Package whatsup-1.13-4.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing whatsup-1.13-4.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-6655/whatsup-1.13-4.el6 then log in and leave karma (feedback).
whatsup-1.13-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
whatsup-1.13-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.