hi rename django-recaptcha to python-django-recaptcha SPEC: http://lbazan.fedorapeople.org/python-django-recaptcha.spec SRPM: http://lbazan.fedorapeople.org/python-django-recaptcha-0.0.4-1.fc17.src.rpm $ rpmlint -v python-django-recaptcha.spec python-django-recaptcha.spec:17: W: mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 3) python-django-recaptcha.spec: I: checking-url http://pypi.python.org/packages/source/d/django-recaptcha/django-recaptcha-0.0.4.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Regards.
Some drive-by comments: - you need an obsoletes: - no need to clean up the build-root any more - why did you remove the old changelog entries? They still belong to the package - defattrs not required - you should enable the tests in a %check section
I'll take this review. Matthias's comments are completely relevant, please fix them and post the updated spec/srpm before we can continue this review.
Ping, any progress here?
SPEC: http://lbazan.fedorapeople.org/python-django-recaptcha.spec SRPM: http://lbazan.fedorapeople.org/python-django-recaptcha-0.0.4-2.fc17.src.rpm
Phew, the version in our repositories is: 0.1-3, not 0.0.4 Doing a version comparison, your package will not be taken as an update. What happened to the old package? It looks like you're taking totally different sources. old one for django-recaptcha: https://code.google.com/p/recaptcha-django/source/browse/#svn%2Ftrunk%2Frecaptcha_django new ones: https://github.com/praekelt/django-recaptcha/tree/master/captcha I'd say, this is a totally different package, not a rename. Nevertheless, when you want to continue, you should take care of obsoleting that old package, and of course deprecate that old package as fast as you can.
(In reply to comment #5) > Phew, > > the version in our repositories is: 0.1-3, not 0.0.4 > Doing a version comparison, your package will not be taken as an update. > > What happened to the old package? It looks like you're taking totally > different sources. > old one for django-recaptcha: > https://code.google.com/p/recaptcha-django/source/browse/ > #svn%2Ftrunk%2Frecaptcha_django > > new ones: https://github.com/praekelt/django-recaptcha/tree/master/captcha > > I'd say, this is a totally different package, not a rename. > Yep, looks like that. Probably the best way to do is just retire the old package, pointing out that upstream is dead and introducing this one. What I think is appropriate here is using only Obsoletes (not Provides, as the API is different, I think). Also, introducing Epoch: 1 will solve the versioning problem. > Nevertheless, when you want to continue, you should take care of obsoleting > that old package, and of course deprecate that old package as fast as you > can.
Ok the other is totally obsolete preferable to use this new, exactly I must do? Regards!
(In reply to comment #7) > Ok > > the other is totally obsolete preferable to use this new, exactly I must do? > - Use only Obsoletes:, not Provides: tag. - Once you finish the package review and build it, retire the old package (django-recaptcha) exactly as mentioned in [1]. Once you do that, the old package will no longer be in the official repos, so no Epoch or anything else will be needed. > Regards! [1] https://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life
Ping, any progress on this one?
and another ping
I'll take the role of Luis here, he spoke with me to complete the review- Please Matthias or Bohuslav, appreciate it if you can finish the review. thanks for advance SPEC: http://echevemaster.fedorapeople.org/python-django-recaptcha/python-django-recaptcha.spec SRPM: http://echevemaster.fedorapeople.org/python-django-recaptcha/python-django-recaptcha-0.0.6-1.fc19.src.rpm
Eduardo, thank you for trying to solve this unfortunate situation. For take-over: Please close this request and re-open a new one. Luis, you're still not off the hook. You need to retire django-recaptcha properly, once the new package is introduced. Also I'd announce the change to fedora-devel list (about replacing one with a totally changed other).
Hi Matthias http://lbazan.fedorapeople.org/python-django-recaptcha.spec http://lbazan.fedorapeople.org/python-django-recaptcha-0.0.6-1.fc20.src.rpm Now the test run! Best Regards!
Why do you still use the Group tag? It's already deprecated.
http://lbazan.fedorapeople.org/python-django-recaptcha.spec http://lbazan.fedorapeople.org/python-django-recaptcha-0.0.6-2.fc20.src.rpm
New SPEC: http://lbazan.fedorapeople.org/python-django-recaptcha.spec New SRPM http://lbazan.fedorapeople.org/python-django-recaptcha-0.0.9-1.fc20.src.rpm
New Spec: http://lbazan.fedorapeople.org/python-django-recaptcha.spec New SRPM: http://lbazan.fedorapeople.org/python-django-recaptcha-0.0.9-2.fc20.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6620128
Sorry for the long response time. My notes: - When renaming a package, you should not only Obsolete it, but also Provide it [1]. - rpmlint reports mixed use of tabs and spaces in specfile. Please decide for one and use it throughout the whole specfile. - The README file says "client.py taken from recaptcha-client licenced MIT/X11 by Mike Crawford." - I therefore suggest changing License tag to "BSD and MIT". - The tests are not actually run. Mock outputs this: DEBUG: + /usr/bin/python2 -m unittest DEBUG: ---------------------------------------------------------------------- DEBUG: Ran 0 tests in 0.000s Please look into this. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Hi SPEC: http://lbazan.fedorapeople.org/python-django-recaptcha.spec SRPM: http://lbazan.fedorapeople.org/python-django-recaptcha-0.0.9-3.fc20.src.rpm - When renaming a package, you should not only Obsolete it, but also Provide it [1]. --Fixed - rpmlint reports mixed use of tabs and spaces in specfile. Please decide for one and use it throughout the whole specfile. --Fixed - The README file says "client.py taken from recaptcha-client licenced MIT/X11 by Mike Crawford." - I therefore suggest changing License tag to "BSD and MIT". --Fixed - The tests are not actually run. Mock outputs this: DEBUG: + /usr/bin/python2 -m unittest DEBUG: ---------------------------------------------------------------------- DEBUG: Ran 0 tests in 0.000s Please look into this. Test Fail --https://github.com/praekelt/django-recaptcha/issues/41 <- I create the issue in upstream Regards!
I just stumbled upon this: /usr/lib/python2.7/site-packages/captcha is already owned and used by python-django-simple-captcha So, this package conflicts with python-django-simple-captcha Would it be possible to rename that dir in this package here?
Created attachment 942493 [details] patch to fix various packaging issues Attaching a spec file patch
Rahul, as far as I can see, the patch removes plenty of stuff from the spec, but does not add anything. Further more, it's a patch on django-recaptcha. Maybe you uploaded the wrong file by accident?
Created attachment 942663 [details] new spec file based on django-recapatcha.spec Yes. Ignore the previous "patch".
Closing, as I didn't saw a movement here for a long time. Please reopen, if still interested.