Bug 845120 - JMX plugin has moved some classes, other plugins may rely on
Summary: JMX plugin has moved some classes, other plugins may rely on
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Plugin -- Other
Version: JON 3.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
: JON 3.1.1
Assignee: Heiko W. Rupp
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On: 845118
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-01 20:36 UTC by Heiko W. Rupp
Modified: 2018-11-29 20:17 UTC (History)
4 users (show)

Fixed In Version:
Clone Of: 845118
Environment:
Last Closed: 2013-09-11 10:58:22 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Heiko W. Rupp 2012-08-01 20:36:18 UTC 
+++ This bug was initially created as a clone of Bug #845118 +++

Description of problem:

Plugins like Infinispan plugin may fail with 

java.lang.Exception: Discovery component invocation failed.
        at org.rhq.core.pc.util.DiscoveryComponentProxyFactory$ComponentInvocationThread.call(DiscoveryComponentProxyFactory.java:297)
  [...]
Caused by: java.lang.NoClassDefFoundError: org/rhq/plugins/jmx/ObjectNameQueryUtility
        at org.infinispan.rhq.CacheManagerDiscovery.createDiscoveredResource(CacheManagerDiscovery.java:76)
        at org.infinispan.rhq.CacheManagerDiscovery.discoverResources(CacheManagerDiscovery.java:62)


Turns out we moved the ObjectNameQueryUtility to the util sub-package in commit
d06bde3ab789c06f603836525d7281e7a96bad85 on 2012-01-20

--- Additional comment from hrupp on 2012-08-01 16:35:17 EDT ---

master 4f60260d2afe0
Comment 1 Mike Foley 2012-08-01 21:04:35 UTC 
We should rather make sure, that we don't make such incompatible changes. Those classes are "the public api" of the JMX plugin.

Can we add a unit-test to hold this public API of the JMX plugin constant?
Can we change the animal-sniffer to detect changes in the public API of the JMX plugin?

I would truly like to prevent the introduction of further regressiosn of this type.
Comment 2 Mike Foley 2012-08-01 21:08:29 UTC 
also ... can we do a code search to identify what other plugins may have regerssed because of this change?
Comment 3 Mike Foley 2012-08-01 21:43:09 UTC 
task for the QE countermeasure.  https://engineering.redhat.com/trac/jon/ticket/253

i would also like a dev countermeasure included here  ...
Comment 4 Heiko W. Rupp 2012-08-02 16:16:39 UTC 
release branch af6c7aa
Comment 5 John Sanda 2012-08-14 02:16:32 UTC 
Moving to ON_QA since JON 3.1.1 ER2 build is availble - https://brewweb.devel.redhat.com/buildinfo?buildID=228250
Comment 6 Mike Foley 2012-08-31 18:50:25 UTC 
dev added an api diff checker to take care of this.
Note You need to log in before you can comment on or make changes to this bug.