Red Hat Bugzilla – Bug 845342
Review Request: rubygem-ruby-hmac - provides common interface to HMAC functionality
Last modified: 2015-02-17 08:48:10 EST
RPM Spec: http://mo.morsi.org/files/rpms/rubygem-ruby-hmac.spec SRPM: http://mo.morsi.org/files/rpms/rubygem-ruby-hmac-0.4.0-6.fc17.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4351563 Description: This module provides common interface to HMAC functionality. HMAC is a kind of "Message Authentication Code" (MAC) algorithm whose standard is documented in RFC2104. Namely, a MAC provides a way to check the integrity of information transmitted over or stored in an unreliable medium, based on a secret key. Originally written by Daiki Ueno. Converted to a RubyGem by Geoffrey Grosenbach Obsoletes: rubygem-hmac
I'll take it for a review.
There are two things that I found wrong on this package: - Wrong provides/obsoletes. According to [1], they should look like this: Provides: rubygem(hmac) = %{version}-%{release} Obsoletes: rubygem(hmac) < 0.4.0-6 - The specfile still has name rubygem-hmac.spec, although it should now be rubygem-ruby-hmac.spec. Otherwise the package looks good, so it is APPROVED, but please fix the above before comitting to dist-git. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
Thanks for the review. Incorporated you two points, the updated urls can be found here: RPM Spec: http://mo.morsi.org/files/rpms/rubygem-ruby-hmac.spec SRPM: http://mo.morsi.org/files/rpms/rubygem-ruby-hmac-0.4.0-7.fc17.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4366977 New Package SCM Request ======================= Package Name: rubygem-ruby-hmac Short Description: Provides common interface to HMAC functionality Owners: mmorsi Branches: InitialCC:
Git done (by process-git-requests). Bohuslav, please take ownership of review BZs. Thanks!
rubygem-ruby-hmac has been successfully imported / built for rawhide
Package Change Request ====================== Package Name: rubygem-ruby-hmac New Branches: epel7 Owners: mmorsi humaton FAS username: humaton
Git done (by process-git-requests).