Red Hat Bugzilla – Bug 845568
Review Request: vim-command-t - An extremely fast, intuitive mechanism for opening files in VIM
Last modified: 2012-09-17 18:16:37 EDT
Spec URL: http://people.redhat.com/vondruch/vim-command-t.spec
SRPM URL: http://people.redhat.com/vondruch/vim-command-t-1.4-1.fc18.src.rpm
The Command-T plug-in for VIM provides an extremely fast, intuitive mechanism
for opening files with a minimal number of keystrokes. It's named "Command-T"
because it is inspired by the "Go to File" window bound to Command-T
Files are selected by typing characters that appear in their paths, and are
ordered by an algorithm which knows that characters that appear in certain
locations (for example, immediately after a path separator) should be given
Fedora Account System Username: vondruch
I'll take this for a review.
- You should include Requires: ruby-libs, as it contains directory where the ext.so file is stored. If we ever have ruby(abi) also provided by JRuby or Rubinius, the file might end up useless and in an unowned directory (AFAICS it only works with MRI Ruby anyway).
Otherwise, the package looks good, works ok and rpmlint is silent => APPROVED (please don't forget to add the Requires: as mentioned above).
Thank you for a review.
Regarding the ruby-libs, there is automatically added require for libruby.so.1.9, so I guess that the ruby-libs require is not needed.
New Package SCM Request
Package Name: vim-command-t
Short Description: An extremely fast, intuitive mechanism for opening files in VIM
Branches: f17 f18
vim-command-t-1.4-1.fc18 has been submitted as an update for Fedora 18.
vim-command-t-1.4-1.fc17 has been submitted as an update for Fedora 17.
vim-command-t-1.4-1.fc17 has been pushed to the Fedora 17 testing repository.
vim-command-t-1.4-1.fc17 has been pushed to the Fedora 17 stable repository.
vim-command-t-1.4-1.fc18 has been pushed to the Fedora 18 stable repository.