Spec URL: http://www.matthias-runge.de/fedora/python-django-reversion.spec SRPM URL: http://www.matthias-runge.de/fedora/python-django-reversion-1.6.2-1.fc17.src.rpm Description: Reversion is an extension to the Django web framework that provides comprehensive version control facilities. Features: * Roll back to any point in a model's history - an unlimited undo facility! * Recover deleted models - never lose data again! * Admin integration for maximum usability. * Group related changes into revisions that can be rolled back in a single transaction. * Automatically save a new version whenever your model changes using Django's flexible signalling framework. * Automate your revision management with easy-to-use middleware. Reversion can be easily added to your existing Django project with a minimum of code changes. Fedora Account System Username: mrunge please note, this is a review required for package rename. koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=4362341 [mrunge@mrungexp SPECS]$ rpmlint ./python-django-reversion.spec ../SRPMS/python-django-reversion-1.6.2-1.fc17.src.rpm ../RPMS/noarch/python-django-reversion-1.6.2-1.fc17.noarch.rpm python-django-reversion.src: W: spelling-error %description -l en_US signalling -> signaling, signal ling, signal-ling python-django-reversion.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight python-django-reversion.noarch: W: spelling-error %description -l en_US signalling -> signaling, signal ling, signal-ling python-django-reversion.noarch: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight 2 packages and 1 specfiles checked; 0 errors, 4 warnings.
I'll review this.
tl;dr: Please conditionalize the dependency on python-django. It should be possible to build this package also on Fedora 17, which has Django-1.4.1 rather than python-django. Also, you can drop the 'defattr' line in %files unless you intend to package this for EL5. fedora-review 0.2.0 output: Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: EXTRA Spec file according to URL is the same as in SRPM. [ ]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [ ]: MUST Package contains no bundled libraries. [ ]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [ ]: MUST Sources contain only permissible code or content. [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files -f %{name}.lang section. This is OK if packaging for EPEL5. Otherwise not needed [ ]: MUST Macros in Summary, %description expandable at SRPM build time. [ ]: MUST Package contains desktop file if it is a GUI application. [ ]: MUST Development files must be in a -devel package [ ]: MUST Package requires other packages for directories it uses. [ ]: MUST Package uses nothing in %doc for runtime. [ ]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [ ]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [ ]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* UNKNOWN" For detailed output of licensecheck see file: /dev/shm/845922-python-django-reversion/licensecheck.txt [ ]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [ ]: MUST Package is named according to the Package Naming Guidelines. [ ]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [ ]: MUST Package obeys FHS, except libexecdir and /usr/target. [ ]: MUST Package must own all directories that it creates. [ ]: MUST Package does not own files or directories owned by other packages. [!]: MUST Package installs properly. Note: Installation errors (see attachment) [ ]: MUST Package is not relocatable. [ ]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [ ]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [ ]: SHOULD Package functions as described. [ ]: SHOULD Latest version is packaged. [ ]: SHOULD Package does not include license text files separate from upstream. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0 (django-reversion-1.6.2.tar.gz) [x]: SHOULD SourceX is a working URL. [ ]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: SHOULD Package should compile and build into binary rpms on all supported architectures. [ ]: SHOULD %check is present and all tests pass. [ ]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files -f %{name}.lang section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions Installation errors ------------------- INFO: mock.py version 1.1.25 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.25 INFO: Mock Version: 1.1.25 Start: lock buildroot INFO: installing package(s): /dev/shm/845922-python-django-reversion/results/python-django-reversion-1.6.2-1.fc16.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-16-x86_64/root/', 'install', '/dev/shm/845922-python-django-reversion/results/python-django-reversion-1.6.2-1.fc16.noarch.rpm', '--setopt=tsflags=nocontexts'] Error: Package: python-django-reversion-1.6.2-1.fc16.noarch (/python-django-reversion-1.6.2-1.fc16.noarch) Requires: python-django You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: python-django-reversion-1.6.2-1.fc16.src.rpm python-django-reversion-1.6.2-1.fc16.noarch.rpm python-django-reversion.src: W: spelling-error %description -l en_US signalling -> signaling, signal ling, signal-ling python-django-reversion.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight python-django-reversion.noarch: W: spelling-error %description -l en_US signalling -> signaling, signal ling, signal-ling python-django-reversion.noarch: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-django-reversion (none): E: no installed packages by name python-django-reversion 0 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- python-django-reversion-1.6.2-1.fc16.noarch.rpm (rpmlib, GLIBC filtered): python(abi) = 2.7 python-django Provides -------- python-django-reversion-1.6.2-1.fc16.noarch.rpm: django-reversion = 1.6.2-1.fc16 python-django-reversion = 1.6.2-1.fc16 MD5-sum check ------------- http://github.com/downloads/etianen/django-reversion/django-reversion-1.6.2.tar.gz : MD5SUM this package : 311f6cd65dc26e70df3b34f723fc33e6 MD5SUM upstream package : 311f6cd65dc26e70df3b34f723fc33e6 Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09 Command line :/usr/bin/fedora-review -b 845922 External plugins:
On further reflection, I just realized this was a rename review for F18 only, and will not be updating the F17 package on that distribution. Package is APPROVED.
Thank you very much! This package is intended to replace django-reversion in f18+. It's not intended to be built for earlier versions. New Package SCM Request ======================= Package Name: python-django-reversion Short Description: Version control extension for the Django web framework Owners: mrunge Branches: f18 devel
Git done (by process-git-requests). f18 will branch tomorrow.
Imported to rawhide and built. Thanks