Bug 846819 - Broken dashboard portlets or portlets with invalid configuration SHOULD NOT prevent the entire dashboard from working
Summary: Broken dashboard portlets or portlets with invalid configuration SHOULD NOT p...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: UI
Version: JON 3.1.0
Hardware: All
OS: All
low
high
Target Milestone: DR01
: JON 3.2.1
Assignee: Jirka Kremser
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-08 19:53 UTC by Larry O'Leary
Modified: 2018-11-28 19:39 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-05-08 17:43:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 846818 0 unspecified CLOSED Dashboard Resource Metric Graph portlet allows invalid resource/resource ID to be used 2021-02-22 00:41:40 UTC

Internal Links: 846818

Description Larry O'Leary 2012-08-08 19:53:46 UTC
Description of problem:
If a dashboard contains a portlet for which configuration becomes invalid or other errors occur within the portlet, the dashboard fails to load.

This can be seen in Bug 846818.

Version-Release number of selected component (if applicable):
JON 3.1.0

How reproducible:
Always

Comment 1 mark yarborough 2012-11-06 20:05:17 UTC
Per 3.1.2 triage with loleary, mfoley, ccrouch, asantos: Okay to move to JON 3.2.

Comment 2 Heiko W. Rupp 2013-08-09 15:56:58 UTC
The Dashboard should wrap all individual portlet creation into try-catch-blocks so that a bad portlet will not blow up Dashoard

Comment 3 Jirka Kremser 2014-01-09 15:41:18 UTC
branch:  master
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=1e2f74e4a
time:    2014-01-09 16:39:45 +0100
commit:  1e2f74e4ad545ad92ad39fdca6f691fd85608d2c
author:  Jirka Kremser - jkremser
message: [BZ 846819] - Broken dashboard portlets or portlets with invalid
         configuration SHOULD NOT prevent the entire dashboard from
         working - surrounding the risky interaction with particular
         portlets into try-catch block to make the logic little bit more
         robust. Now, exception thrown from a portlet doesn't affect
         other portlets, so the portlets are more autonomous so to
         speak.

Comment 6 Jay Shaughnessy 2014-01-10 19:01:37 UTC
release/jon3.2.x commit 4e96f844a18814912a1728ad737394681d7e2de2

  Cherry-Pick Master 1e2f74e4ad545ad92ad39fdca6f691fd85608d2c

Comment 7 Simeon Pinder 2014-02-18 15:08:27 UTC
Moving to ON_QA as available for testing in the following brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=336752

Note: the installed version is still JON 3.2.0.GA by design and this represents part of the payload for JON 3.2.1 also known as cumulative patch 1 for 3.2.0.GA.  How this will be delivered to customers is still being discussed.

Comment 9 Mike Foley 2014-02-19 14:32:45 UTC
Verified JON 3.2.1 DR1.  Due to input validation, it was impossible to enter invalid data ...due to input validation ... so no non-customer-facing error message could appear.

Comment 10 Mike Foley 2014-05-08 17:43:57 UTC
JON 3.2.1 released week of 5/5/2014


Note You need to log in before you can comment on or make changes to this bug.