Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 847010

Summary: Is not possible use remote command script with escape dollar and backslash (\$)
Product: [Community] Spacewalk Reporter: Jan Dlouhy <dlouhy.jan>
Component: WebUIAssignee: Jan Pazdziora (Red Hat) <jpazdziora>
Status: CLOSED CURRENTRELEASE QA Contact: Red Hat Satellite QA List <satqe-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.7CC: jpazdziora
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-01 16:21:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 871344    

Description Jan Dlouhy 2012-08-09 12:41:51 UTC
Description of problem:
If are inserted char backslash and dollar (\$) in remote command script, finish spacewalk web with error 500 Error - Internal Server Error.


Version-Release number of selected component (if applicable):
Spacewalk 1.7


How reproducible:
Insert char backslash and dollar together (\$) or in quotation marks ("\$") in to remote command script. If are inserted in apostrophe ('\$') script works good. 


Steps to Reproduce:
1.Spacewalk system -> Details -> Remote Command:
Run as user*: root
Run as group*: root
Timeout (seconds): 600
Script*:
#!/bin/sh
echo "\$"
=> error 500 Error - Internal Server Error
  
Actual results:
Is not possible use script if you need escape dollar with backslash.

Expected results:
Fixed bug in Web GUI it will enable to use scripts with escape dollar.


Additional info:
none

Comment 1 Tomas Lestach 2012-09-07 11:37:07 UTC
I tried to reproduce the issue both on latest Spacewalk nightly and Spacewalk 1.7, but didn't get any ISE.

In both cases I was able to schedule the remote command and execute it by running rhn_check on the client.

On spw1.7 I use spacewalk-html-1.7.28-1.el5.

Do you still see the issue? Would you, please, try to describe the reproducer more precisely and attach the appropriate logs?

Comment 2 Jan Dlouhy 2012-09-10 13:58:31 UTC
Hello,
unfortunately spacewalk no have error in log (/var/log/rhn/* and catalina.out), but i think where is problem. I used spacewalk with postgresql database and in database log is error:

ERROR:  invalid input syntax for type bytea
STATEMENT:  INSERT
          INTO rhnActionScript
               (id, action_id, script, username, groupname, timeout)
        VALUES (sequence_nextval('rhn_actscript_id_seq'), $1, $2, $3, $4, $5)


I have version of spacewalk + postgresql:
spacewalk-html-1.7.28-1.el6.noarch
postgresql-server-8.4.12-1.el6_2.x86_64
spacewalk-java-postgresql-1.7.54-1.el6.noarch
spacewalk-postgresql-1.7.3-1.el6.noarch
spacewalk-backend-sql-postgresql-1.7.38-1.el6.noarch


I can help you with description error? Thank you very much for help with problem.

Comment 3 Tomas Lestach 2012-09-14 13:38:23 UTC
Reproduced on latest nightly ...

Error message:
  RHN::Exception: DBD::Pg::st execute failed: ERROR:  invalid input syntax for type bytea
  RHN::DB /usr/share/perl5/vendor_perl/RHN/DB.pm 121 RHN::Exception::DB::throw
  RHN::DB::st /usr/share/perl5/vendor_perl/RHN/DB.pm 452 RHN::DB::handle_error
  RHN::DB::Scheduler /usr/share/perl5/vendor_perl/RHN/DB/Scheduler.pm 1563 RHN::DB::st::execute_h
  Sniglets::Servers /usr/share/perl5/vendor_perl/Sniglets/Servers.pm 798 RHN::DB::Scheduler::schedule_remote_command
  PXT::ApacheHandler /usr/share/perl5/vendor_perl/PXT/ApacheHandler.pm 482 Sniglets::Servers::remote_command_cb
  PXT::ApacheHandler /usr/share/perl5/vendor_perl/PXT/ApacheHandler.pm 103 PXT::ApacheHandler::pxt_parse_data
  PXT::ApacheHandler /usr/share/perl5/vendor_perl/PXT/ApacheHandler.pm 103 (eval)
  main -e 0 PXT::ApacheHandler::handler
  main -e 0 (eval)

Comment 4 Jan Pazdziora (Red Hat) 2012-10-12 12:46:33 UTC
Fixed in Spacewalk nightly, 4148c37113015260df7982d81f8e5dbb6b522c41.

Comment 5 Jan Pazdziora (Red Hat) 2012-10-30 19:25:53 UTC
Moving ON_QA. Packages that address this bugzilla should now be available in yum repos at http://yum.spacewalkproject.org/nightly/

Comment 6 Jan Pazdziora (Red Hat) 2012-11-01 16:21:44 UTC
Spacewalk 1.8 has been released: https://fedorahosted.org/spacewalk/wiki/ReleaseNotes18