Galder Zamarreño <galder.zamarreno> updated the status of jira ISPN-2187 to Resolved

Galder Zamarreño <galder.zamarreno> made a comment on jira ISPN-2187

I think you're confusing two things here:

1. The putForExternalRead() operation

2. The PUT_FOR_EXTERNAL_READ flag.

The second is simply used internally to do some optimisations when we're executing an PFER operation. If you really want a put() op to behave like PFER, you need to pass all this flags:

https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L356

Martin Gencur <mgencur> made a comment on jira ISPN-2187

Galder, we should change the JavaDoc in such a case. Currently it says this:
{code:java}
 /**
    * Flags the invocation as a {@link Cache#putForExternalRead(Object, Object)} call, as opposed to a regular
    * {@link Cache#put(Object, Object)}.
    */
   PUT_FOR_EXTERNAL_READ,
{code}

We should be more precise here as users cannot be sure how it exactly works (I was confused too).

Galder Zamarreño <galder.zamarreno> made a comment on jira ISPN-2187

I've changed the javadoc so that users realise this is an internal flag and they should not use it. It will be refactored in the future.

Galder Zamarreño <galder.zamarreno> updated the status of jira ISPN-2187 to Reopened

Martin Gencur <mgencur> made a comment on jira ISPN-2187

Thanks Galder:)

Clarify if this should be included in JDG 6.0.1 versus 6.1. (The jira was target for ISPN 5.2 as of 15-Aug)

Shouldn't we close this as WONTFIX? AFAIK, this was just badly documented flag. It should not be used by normal users, this is an internal flag. This was fixed in Infinspan by modifying the javadoc for this flag. Or are we planning to close this once the proper javadoc is backported to JDG?

ttarrant will add jira links as appropriate.

This product has been discontinued or is no longer tracked in Red Hat Bugzilla.