Description of problem: Got the following issues during review of halibut package: > [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: Clean is needed only if supporting EPEL > See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > [!]: MUST Each %files section contains %defattr if rpm < 4.4 > Note: defattr(....) present in %files -n vim-halibut section. This is OK > if packaging for EPEL5. Otherwise not needed > See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions > [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > Note: rm -rf is only needed if supporting EPEL5 The first one got fixed in fedora-review-0.2.2-1. The rest seems to be the same story. Although the second one matches the guidelines, classification as "Issue MUST" is confusing. Version-Release number of selected component (if applicable): fedora-review-0.2.2-1 How reproducible: Always Steps to Reproduce: 1. Review EPEL package Actual results: Reported issues Expected results: Reported no issues, or issues turned to tips. Additional info:
Fixed "defattr" check in bd82abb2. The rest should already have been fixed (changed to SHOULD) in 0.2.2 so I'll have to re-check.
fedora-review-0.3.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fedora-review-0.3.0-1.fc16
fedora-review-0.3.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fedora-review-0.3.0-1.fc17
fedora-review-0.3.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fedora-review-0.3.0-1.fc18
Package fedora-review-0.3.0-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing fedora-review-0.3.0-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-14663/fedora-review-0.3.0-1.fc18 then log in and leave karma (feedback).
fedora-review-0.3.0-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.