Spec URL: http://labs.linuxnetz.de/bugzilla/perl-Date-Holidays-DE.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/perl-Date-Holidays-DE-1.6-1.src.rpm Description: A perl module that creates a list of German holidays in a given year. It knows about special holiday regulations for all of Germany's federal states and also about "semi-holidays" and religious "silent days" that will be treated as holidays on request. Holidays that occur on weekends can be excluded from the generated list. The generated list can also be freely formatted using regular strftime() format definitions. The perl module is going to be imported to all active Fedora and EPEL branches.
Source tar ball is original (verified from <http://search.cpan.org/CPAN/authors/id/M/MS/MSCHMITT/Date-Holidays-DE-1.6.tar.gz>, SHA-256: e1bc9c15123ede6432745afad846557b747bf8c2b587f4b713eb77f4da571968). Ok. Source0 and URL are usable. Ok. Summary verified from DE.pm. Ok. Description verified from README. Ok. License verified from README. Ok. No XS code, noarch BuildArch is Ok. TODO: Remove explicit %defattr from %files section. TODO: Build-require `perl(Time::Local)' because the package can dual-live in the future (DE.pm:7, http://search.cpan.org/~drolsky/Time-Local/). TODO: Build-require `perl(Exporter)' because the package can dual-live in the future (DE.pm:13, http://search.cpan.org/~toddr/Exporter/). TODO: Build-require `perl(Test)' because the package can dual-live in the future (test.pl:8, http://search.cpan.org/~sburke/Test/). All tests pass. Ok. $ rpmlint perl-Date-Holidays-DE.spec ../SRPMS/perl-Date-Holidays-DE-1.6-1.fc19.src.rpm ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm perl-Date-Holidays-DE.spec:31: W: rpm-buildroot-usage %build perl Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor perl-Date-Holidays-DE.spec:40: W: macro-in-comment %doc perl-Date-Holidays-DE.src: W: spelling-error %description -l en_US strftime -> trimmest perl-Date-Holidays-DE.src:31: W: rpm-buildroot-usage %build perl Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor perl-Date-Holidays-DE.src:40: W: macro-in-comment %doc perl-Date-Holidays-DE.noarch: W: spelling-error %description -l en_US strftime -> trimmest 2 packages and 1 specfiles checked; 0 errors, 6 warnings. FIX: Escape %doc in the comment with per-cent to prevent from rpm-evaluation. TODO: Remove the `PREFIX=$RPM_BUILD_ROOT%{_prefix}' argument from `perl Makefile.PL' command. It's not necessary. $ rpm -q -lv -p ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Sep 12 14:33 /usr/share/doc/perl-Date-Holidays-DE-1.6 -rw-r--r-- 1 root root 1842 Feb 13 2012 /usr/share/doc/perl-Date-Holidays-DE-1.6/Changes -rw-r--r-- 1 root root 1773 Feb 13 2012 /usr/share/doc/perl-Date-Holidays-DE-1.6/README drwxr-xr-x 2 root root 0 Feb 13 2012 /usr/share/doc/perl-Date-Holidays-DE-1.6/example -rw-r--r-- 1 root root 1862 Aug 15 2010 /usr/share/doc/perl-Date-Holidays-DE-1.6/example/feiertage.pl -rw-r--r-- 1 root root 2102 Aug 27 2009 /usr/share/doc/perl-Date-Holidays-DE-1.6/example/werktage-diff.pl -rw-r--r-- 1 root root 5377 Sep 12 14:33 /usr/share/man/man3/Date::Holidays::DE.3pm.gz drwxr-xr-x 2 root root 0 Sep 12 14:33 /usr/share/perl5/vendor_perl/Date/Holidays -rw-r--r-- 1 root root 17917 Feb 13 2012 /usr/share/perl5/vendor_perl/Date/Holidays/DE.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Date::Calc) >= 5.0 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(POSIX) 1 perl(strict) 1 perl(Time::Local) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Date::Holidays::DE) = 1.6 1 perl-Date-Holidays-DE = 1.6-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Date-Holidays-DE-1.6-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4477510). ??? Please correct all `FIX' issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved.
(In reply to comment #1) > TODO: Remove explicit %defattr from %files section. Will not happen because of Fedora EPEL 5 and 6. > TODO: Build-require `perl(Time::Local)' because the package can dual-live in > the future (DE.pm:7, http://search.cpan.org/~drolsky/Time-Local/). > TODO: Build-require `perl(Exporter)' because the package can dual-live in > the future (DE.pm:13, http://search.cpan.org/~toddr/Exporter/). > TODO: Build-require `perl(Test)' because the package can dual-live in the > future (test.pl:8, http://search.cpan.org/~sburke/Test/). Good pointer, will do so. > FIX: Escape %doc in the comment with per-cent to prevent from rpm-evaluation. Whoops, yes. Will do so. > TODO: Remove the `PREFIX=$RPM_BUILD_ROOT%{_prefix}' argument from `perl > Makefile.PL' command. It's not necessary. Without, I recognized a build failure on Fedora EPEL 5 the first time, thus I re-added it. I will provide an updated spec file if you are fine with my replies here...
Any progress?
Spec URL: http://labs.linuxnetz.de/bugzilla/perl-Date-Holidays-DE.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/perl-Date-Holidays-DE-1.6-2.src.rpm
Spec file changes: --- perl-Date-Holidays-DE.spec.old 2012-08-11 03:16:00.000000000 +0200 +++ perl-Date-Holidays-DE.spec 2014-07-19 01:28:06.000000000 +0200 @@ -6,13 +6,14 @@ Summary: Perl module to determine German holidays Name: perl-Date-Holidays-DE Version: 1.6 -Release: 1%{?dist} +Release: 2%{?dist} License: MIT Group: Development/Libraries URL: http://search.cpan.org/dist/%{pkgname}/ Source: http://search.cpan.org/CPAN/authors/id/M/MS/MSCHMITT/%{pkgname}-%{version}.tar.gz Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) BuildRequires: perl(ExtUtils::MakeMaker), perl(Date::Calc) >= 5.0 +BuildRequires: perl(Exporter), perl(Test), perl(Time::Local) BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) @@ -37,7 +38,7 @@ find $RPM_BUILD_ROOT \( -name perllocal.pod -o -name .packlist \) -exec rm -f {} \; chmod -R u+w $RPM_BUILD_ROOT/* -# Don't add dependencies for %doc +# Don't add dependencies for %%doc chmod -x example/*.pl %check @@ -53,6 +54,9 @@ %{perl_vendorlib}/Date/Holidays/ %changelog +* Sat Jul 19 2014 Robert Scheck <robert> 1.6-2 +- Changes to match with Fedora Packaging Guidelines (#847420) + * Sat Aug 11 2012 Robert Scheck <robert> 1.6-1 - Upgrade to 1.6 (#847420) - Initial spec file for Fedora and Red Hat Enterprise Linux > > TODO: Remove explicit %defattr from %files section. > Will not happen because of Fedora EPEL 5 and 6. Not addressed. Were did you get the macro is needed for EPEL5 <https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions>? > TODO: Build-require `perl(Time::Local)' because the package can dual-live in > the future (DE.pm:7, http://search.cpan.org/~drolsky/Time-Local/). > TODO: Build-require `perl(Exporter)' because the package can dual-live in > the future (DE.pm:13, http://search.cpan.org/~toddr/Exporter/). > TODO: Build-require `perl(Test)' because the package can dual-live in the > future (test.pl:8, http://search.cpan.org/~sburke/Test/). +BuildRequires: perl(Exporter), perl(Test), perl(Time::Local) Ok. > FIX: Escape %doc in the comment with per-cent to prevent from rpm-evaluation. -# Don't add dependencies for %doc +# Don't add dependencies for %%doc Ok. > TODO: Remove the `PREFIX=$RPM_BUILD_ROOT%{_prefix}' argument from > `perl Makefile.PL' command. It's not necessary. Not addressed. $ rpmlint perl-Date-Holidays-DE.spec ../SRPMS/perl-Date-Holidays-DE-1.6-2.fc22.src.rpm ../RPMS/noarch/perl-Date-Holidays-DE-1.6-2.fc22.noarch.rpm perl-Date-Holidays-DE.spec:32: W: rpm-buildroot-usage %build perl Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor perl-Date-Holidays-DE.src: W: spelling-error %description -l en_US strftime -> trimmest perl-Date-Holidays-DE.src:32: W: rpm-buildroot-usage %build perl Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor perl-Date-Holidays-DE.noarch: W: spelling-error %description -l en_US strftime -> trimmest 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7170924). Ok. Resolution: Package APPROVED.
(In reply to Petr Pisar from comment #5) > > > TODO: Remove explicit %defattr from %files section. > > Will not happen because of Fedora EPEL 5 and 6. > Not addressed. > > Were did you get the macro is needed for EPEL5 > <https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#File_Permissions>? You are right. I will remove the macro after the git import (to allow the tracking/verification). > Resolution: Package APPROVED. Thank you very much for the package review!
New Package SCM Request ======================= Package Name: perl-Date-Holidays-DE Short Description: Perl module to determine German holidays Upstream URL: http://search.cpan.org/dist/Date-Holidays-DE/ Owners: robert Branches: f19 f20 f21 el5 el6 epel7 InitialCC:
Git done (by process-git-requests).
perl-Date-Holidays-DE-1.6-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Date-Holidays-DE-1.6-2.fc20
perl-Date-Holidays-DE-1.6-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Date-Holidays-DE-1.6-2.fc19
perl-Date-Holidays-DE-1.6-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Date-Holidays-DE-1.6-2.el6
perl-Date-Holidays-DE-1.6-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Date-Holidays-DE-1.6-2.el5
perl-Date-Holidays-DE-1.6-2.el5 has been pushed to the Fedora EPEL 5 testing repository.
perl-Date-Holidays-DE-1.6-2.fc19 has been pushed to the Fedora 19 stable repository.
perl-Date-Holidays-DE-1.6-2.fc20 has been pushed to the Fedora 20 stable repository.
perl-Date-Holidays-DE-1.6-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
perl-Date-Holidays-DE-1.6-2.el5 has been pushed to the Fedora EPEL 5 stable repository.