Spec URL: http://threebean.org/rpm/python-tbgrep.spec SRPM URL: http://threebean.org/rpm/python-tbgrep-0.2.0-1.fc17.src.rpm Description: A module & command-line tool for extracting Python tracebacks from text. $ tbgrep file1 file2 file3 $ tail -f logfile | tbgrep tbgrep can extract tracebacks from logs of various formats. For example, CherryPy starts the traceback on a line with other details (like module, timestamp, etc), but the rest of the trace starts at the beginning of the line. Apache logs, on the other hand, will prefix each line of the traceback with this information. tbgrep is designed to these kinds of situations Fedora Account System Username: ralph rpmlint output -------------- --- ~/rpmbuild » rpmlint {SPECS,SRPMS}/python-tbgrep* python-tbgrep.src: W: spelling-error %description -l en_US tracebacks -> trace backs, trace-backs, racetracks python-tbgrep.src: W: spelling-error %description -l en_US logfile -> log file, log-file, misfile python-tbgrep.src: W: spelling-error %description -l en_US traceback -> trace back, trace-back, racetrack python-tbgrep.src: W: spelling-error %description -l en_US timestamp -> time stamp, time-stamp, times tamp 1 packages and 1 specfiles checked; 0 errors, 4 warnings.
I will review this package
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [X]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [X]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package contains desktop file if it is a GUI application. [-]: MUST Development files must be in a -devel package [-]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)" For detailed output of licensecheck see file: /home/lmacken/reviews/847571-python-tbgrep/licensecheck.txt [-]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [-]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL5 is required [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [!]: SHOULD Latest version is packaged. I just released 0.2.1, which contains the LICENSE file [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX tarball generation or download is documented. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0 (tbgrep-0.2.0.tar.gz) [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. Needs to run nosetests instead of 'setup.py test' to get the suite to run properly. This will require a BuildRequires: python-nose [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Rpmlint ------- Checking: python-tbgrep-0.2.0-1.fc17.src.rpm python-tbgrep-0.2.0-1.fc17.noarch.rpm python-tbgrep.src: W: spelling-error %description -l en_US tracebacks -> trace backs, trace-backs, racetracks python-tbgrep.src: W: spelling-error %description -l en_US logfile -> log file, log-file, misfile python-tbgrep.src: W: spelling-error %description -l en_US traceback -> trace back, trace-back, racetrack python-tbgrep.src: W: spelling-error %description -l en_US timestamp -> time stamp, time-stamp, times tamp python-tbgrep.noarch: W: spelling-error %description -l en_US tracebacks -> trace backs, trace-backs, racetracks python-tbgrep.noarch: W: spelling-error %description -l en_US logfile -> log file, log-file, misfile python-tbgrep.noarch: W: spelling-error %description -l en_US traceback -> trace back, trace-back, racetrack python-tbgrep.noarch: W: spelling-error %description -l en_US timestamp -> time stamp, time-stamp, times tamp python-tbgrep.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tbgrep/commands.py 0644L /usr/bin/env python-tbgrep.noarch: W: dangling-relative-symlink /usr/share/doc/python-tbgrep-0.2.0/README.rst tbgrep/README.rst python-tbgrep.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tbgrep/__init__.py 0644L /usr/bin/env python-tbgrep.noarch: W: no-manual-page-for-binary tbgrep 2 packages and 0 specfiles checked; 2 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python-tbgrep-0.2.0-1.fc17.noarch.rpm (rpmlib, GLIBC filtered): /usr/bin/python python(abi) = 2.7 Provides -------- python-tbgrep-0.2.0-1.fc17.noarch.rpm: python-tbgrep = 0.2.0-1.fc17 MD5-sum check ------------- http://pypi.python.org/packages/source/t/tbgrep/tbgrep-0.2.0.tar.gz : CHECKSUM(SHA256) this package : 5763d831c875b569c5ade3a14535dc6592bf6bc96b9c9b8c6e6605571844895d CHECKSUM(SHA256) upstream package : 5763d831c875b569c5ade3a14535dc6592bf6bc96b9c9b8c6e6605571844895d Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09 Command line :/usr/bin/fedora-review -c -l --user lmacken -a -b 847571 External plugins:
New release for LICENSE file. Tests actually pass without invoking "nosetests" directly. Spec URL: http://threebean.org/rpm/python-tbgrep.spec SRPM URL: http://threebean.org/rpm/python-tbgrep-0.2.2-1.fc17.src.rpm
Looks good, and works as expected. Thanks for packaging this up! APPROVED
New Package SCM Request ======================= Package Name: python-tbgrep Short Description: Extract Python Tracebacks from text Owners: ralph lmacken Branches: f18 f17 f16 el6 InitialCC:
Git done (by process-git-requests).
python-tbgrep-0.2.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2012-11990/python-tbgrep-0.2.2-1.fc18
python-tbgrep-0.2.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-6734/python-tbgrep-0.2.2-1.el6
python-tbgrep-0.2.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
python-tbgrep-0.2.2-1.fc18 has been pushed to the Fedora 18 stable repository.
Package Change Request ====================== Package Name: python-tbgrep New Branches: epel7 Owners: ralph lmacken