Spec URL: http://bkabrda.fedorapeople.org/pkgs/django-keyedcache/python-django-keyedcache.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/django-keyedcache/python-django-keyedcache-1.4.6-1.fc17.src.rpm Description: Django Keyedcache provides utilities and class mixins for simplified development of cache-aware objects. Used in Satchmo Fedora Account System Username: bkabrda Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4384071 Note: this is a rename review request from django-keyedcache - its maintainer doesn't currently have any time, so I took it instead of him.
I noticed that the package was leaving some directories after uninstallation, so I fixed that, here are the newest SPEC/SRPM: SPEC: http://bkabrda.fedorapeople.org/pkgs/django-keyedcache/python-django-keyedcache.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/django-keyedcache/python-django-keyedcache-1.4.6-2.fc17.src.rpm
And now I even added the proper Provides and Obsoletes tags :) SPEC: http://bkabrda.fedorapeople.org/pkgs/django-keyedcache/python-django-keyedcache.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/django-keyedcache/python-django-keyedcache-1.4.6-3.fc17.src.rpm
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package contains desktop file if it is a GUI application. [-]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL5 is required [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX tarball generation or download is documented. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0 (django-keyedcache-1.4-6.tar.gz) [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [!]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames Rpmlint ------- Checking: python-django-keyedcache-1.4.6-3.fc19.src.rpm python-django-keyedcache-1.4.6-3.fc19.noarch.rpm python-django-keyedcache.src: W: spelling-error %description -l en_US mixins -> mixing, mix ins, mix-ins python-django-keyedcache.noarch: W: spelling-error %description -l en_US mixins -> mixing, mix ins, mix-ins 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python-django-keyedcache-1.4.6-3.fc19.noarch.rpm (rpmlib, GLIBC filtered): python(abi) = 2.7 python-django Provides -------- python-django-keyedcache-1.4.6-3.fc19.noarch.rpm: django-keyedcache = 1.4.6-3.fc19 python-django-keyedcache = 1.4.6-3.fc19 MD5-sum check ------------- http://pypi.python.org/packages/source/d/django-keyedcache/django-keyedcache-1.4-6.tar.gz : CHECKSUM(SHA256) this package : b4cfa9f44c74504de5cd05ae9a48f146c96cba23cb5acc29beeaba83c77ba011 CHECKSUM(SHA256) upstream package : b4cfa9f44c74504de5cd05ae9a48f146c96cba23cb5acc29beeaba83c77ba011 Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09 Command line :/usr/bin/fedora-review -b 847763 Since this is a rename request: obsoletes and provides are correct. BuildRequires should read: BuildRequires: python-setuptools BuildRequires: python2-devel I see no other issues; I'm absolutely sure, you'll correct that before importing into scm. Woul you mind, accepting me as co-maintainer?
Matthias, thanks for your review. I will correct the mentioned points before importing. New Package SCM Request ======================= Package Name: python-django-keyedcache Short Description: Utilities for simplified development of cache aware objects Owners: bkabrda mrunge sundaram Branches: f18 InitialCC:
Git done (by process-git-requests).