Red Hat Bugzilla – Bug 848142
Review Request: maliit-plugins - Input method plugins
Last modified: 2012-09-27 10:56:36 EDT
spec: http://pbrobinson.fedorapeople.org/maliit-plugins.spec srpm: http://pbrobinson.fedorapeople.org/maliit-plugins-0.92.4-1.fc17.src.rpm %description Maliit provides a flexible and cross-platform input method plugins. It has a plugin-based client-server architecture where applications act as clients and communicate with the Maliit server via input context plugins. The communication link currently uses D-Bus.
rpmlint: maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/KeyboardUiConstants.js maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/EnglishPortrait.qml maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/DevStub.js maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/meegotouch-keyboard-function-key.svg maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/FunctionKey.qml maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/meegotouch-keyboard-key.svg maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/RussianPortrait.qml maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/Popper.qml maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/popper.svg maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/LandscapeVKB.qml maliit-plugins.i686: W: no-manual-page-for-binary maliit-keyboard-viewer maliit-plugins.i686: W: no-manual-page-for-binary maliit-keyboard-benchmark 3 packages and 1 specfiles checked; 10 errors, 2 warnings. I think you should chmod those "scripts" to 644 because they aren't executable items. License: This looks like a BSD-licensed codebase to me. Will continue the review tomorrow.
Completed the review, can't find any more issues. Looks good to me, provided that the above 2 trivial changes are made.
Will fix the comments above on commit. Thanks for the review New Package GIT Request ======================= Package Name: maliit-plugins Short Description: Input method plugins Owners: pbrobinson Branches: F-18 F-17 InitialCC:
Git done (by process-git-requests).
Imported and built in rawhide