Bug 848142 - Review Request: maliit-plugins - Input method plugins
Summary: Review Request: maliit-plugins - Input method plugins
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daniel Drake
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 848139
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-14 18:18 UTC by Peter Robinson
Modified: 2012-09-27 14:56 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-09-27 14:56:36 UTC
Type: Bug
Embargoed:
dsd: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Peter Robinson 2012-08-14 18:18:29 UTC
spec: http://pbrobinson.fedorapeople.org/maliit-plugins.spec
srpm: http://pbrobinson.fedorapeople.org/maliit-plugins-0.92.4-1.fc17.src.rpm

%description
Maliit provides a flexible and cross-platform input method plugins. It has a
plugin-based client-server architecture where applications act as clients and
communicate with the Maliit server via input context plugins. The communication
link currently uses D-Bus.

Comment 1 Daniel Drake 2012-09-21 22:19:00 UTC
rpmlint:

maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/KeyboardUiConstants.js
maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/EnglishPortrait.qml
maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/DevStub.js
maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/meegotouch-keyboard-function-key.svg
maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/FunctionKey.qml
maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/meegotouch-keyboard-key.svg
maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/RussianPortrait.qml
maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/Popper.qml
maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/popper.svg
maliit-plugins.i686: E: script-without-shebang /usr/share/maliit/plugins/org/nemomobile/LandscapeVKB.qml
maliit-plugins.i686: W: no-manual-page-for-binary maliit-keyboard-viewer
maliit-plugins.i686: W: no-manual-page-for-binary maliit-keyboard-benchmark
3 packages and 1 specfiles checked; 10 errors, 2 warnings.

I think you should chmod those "scripts" to 644 because they aren't executable items.

License: This looks like a BSD-licensed codebase to me.

Will continue the review tomorrow.

Comment 2 Daniel Drake 2012-09-22 16:13:28 UTC
Completed the review, can't find any more issues. Looks good to me, provided that the above 2 trivial changes are made.

Comment 3 Peter Robinson 2012-09-26 15:35:50 UTC
Will fix the comments above on commit. Thanks for the review

New Package GIT Request
=======================
Package Name: maliit-plugins
Short Description: Input method plugins
Owners: pbrobinson
Branches: F-18 F-17
InitialCC:

Comment 4 Gwyn Ciesla 2012-09-26 16:19:40 UTC
Git done (by process-git-requests).

Comment 5 Peter Robinson 2012-09-27 14:56:36 UTC
Imported and built in rawhide


Note You need to log in before you can comment on or make changes to this bug.