Bug 848472
| Summary: | provider api create with bad type id defaults to vsphere | ||
|---|---|---|---|
| Product: | [Retired] CloudForms Cloud Engine | Reporter: | Dave Johnson <dajohnso> |
| Component: | aeolus-conductor | Assignee: | Petr Blaho <pblaho> |
| Status: | CLOSED ERRATA | QA Contact: | Dave Johnson <dajohnso> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1.0.0 | CC: | asettle, dmacpher, morazi, slinaber |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
In the Cloud Engine API, the creation of a provider with a non-existent <provider_type/> resulted in a successful provider creation using vSphere as a default. This fix adds a check to see if the <provider_type/> is valid. The Cloud Engine API now returns an error if the <provider_type/> is invalid.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-04 15:16:15 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dave Johnson
2012-08-15 16:54:45 UTC
There is missing check for nil value of one variable. provider_type = ProviderType.find_by_id(provider_id) return nil when there is no such ProviderType found. The line where is used provider_type.id call is missing if provider_type check. Without that check there will be nil.id call. And there comes interesting part. nil.id behavior is dependent on version of ruby and config options in rails. for fedora 16 ruby 1.8.7-p358 and production environment it returns 4 and notice "warning: Object#id will be deprecated; use Object#object_id" for fedora 16 ruby 1.8.7-p358 and development environment it raises "RuntimeError: Called id for nil, which would mistakenly be 4 -- if you really wanted the id of nil, use object_id" for fedora 17 ruby 1.9.3-p194 and production environment it raises "NoMethodError: undefined method `id' for nil:NilClass" for fedora 17 ruby 1.9.3-p194 and development environment it raises "RuntimeError: Called id for nil, which would mistakenly be 4 -- if you really wanted the id of nil, use object_id" Patch will follow. Note: vsphere was always used because of that nil.id return value of 4 - id of this provider type. Continue: In examples above production environment is how ruby behave. Examples with development env is enhanced by this code - https://github.com/rails/rails/blob/3-0-stable/activesupport/lib/active_support/whiny_nil.rb#L40 . This takes place only when config.whiny_nil = true in rails. So this is the reason why different environments behave differently. in build aeolus-conductor-0.13.3-1.el6cf good 2 go in CFCE v1.1 2012-09-14.5 puddle [root@hp-bl685cg6-01 ~]# curl -X POST -d '<provider><name>errorTest-4sdf6</name><url>http://localhost:3002/api</url><provider_type id="100"/><deltacloud_provider></deltacloud_provider></provider>' -H "Content-Type: application/xml" -H "Accept: application/xml" --insecure -u admin:password https://127.0.0.1:443/conductor/api/providers <errors> <error> <message>Provider type does not exist</message> </error> </errors> [root@hp-bl685cg6-01 ~]# Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2012-1516.html |