Bug 848711 - Review Request: spherical-cow-kde-theme - Spherical Cow KDE Theme
Summary: Review Request: spherical-cow-kde-theme - Spherical Cow KDE Theme
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-16 09:18 UTC by Martin Bříza
Modified: 2013-04-03 08:33 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-03 08:33:10 UTC
jreznik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Martin Bříza 2012-08-16 09:18:02 UTC
Spec URL: http://mbriza.fedorapeople.org/spherical-cow-kde-theme.spec
SRPM URL: http://mbriza.fedorapeople.org/spherical-cow-kde-theme-17.91.0-1.fc16.src.rpm
Description: This is Spherical Cow KDE Theme Artwork containing KDM theme, KSplash theme and Plasma Workspaces theme.
Fedora Account System Username: mbriza

Comment 1 Jaroslav Reznik 2012-08-16 14:12:37 UTC
Name: ok
Version: ok
Summary: ok
Group is not needed anymore, it's optional, see http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
License: ok
URL: ok
Sources: ok (md5sum 4dd5cd9a793a4cb16de2ca5bdfee7ca1)
BuildRoot is not needed anymore, see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
Requires: ok

Provides: ok

Description: ok

Macros used consistently: ok
Package builds: ok

Docs: ok

rpmlint spherical-cow-kde-theme-17.91.0-1.fc16.src.rpm 
spherical-cow-kde-theme.src:61: W: macro-in-comment %{buildroot}
spherical-cow-kde-theme.src:61: W: macro-in-comment %{_kde4_appsdir}
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

The package is based on beefy-miracle-kde-theme (sed work), simple one. You can clean up SPEC according to current guidelines as it's going to the latest Fedora (no need to support EPEL).

APPROVED

Comment 2 Martin Bříza 2012-08-16 22:17:08 UTC
New Package SCM Request
=======================
Package Name: spherical-cow-kde-theme
Short Description: Spherical Cow KDE Theme
Owners: mbriza jreznik
Branches: f18
InitialCC:

Comment 3 Gwyn Ciesla 2012-08-17 11:02:42 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.