Description of problem: Number of process threads increases over time. One such example: "Thread-2461" daemon prio=10 tid=0x000000006103c800 nid=0x5fc0 waiting on condition [0x00002aab178bb000] java.lang.Thread.State: TIMED_WAITING (sleeping) at java.lang.Thread.sleep(Native Method) at com.sun.jmx.remote.internal.ClientCommunicatorAdmin$Checker.run(ClientCommunicatorAdmin.java:154) at java.lang.Thread.run(Thread.java:619) Version-Release number of selected component (if applicable): RHQ 4.4 version of the plugin running. How reproducible: Unclear what specific conditions cause this in my case, but I have seen it almost universally. It could be to discovery failing. There are obvious code paths which can likely lead to this condition worth exploring. Additional info: See: http://stackoverflow.com/questions/564589/dynamic-proxies-with-jmx-can-cause-thread-leaks > When you do: > JMXConnectorFactory.connect(url) > Make sure to close it when you're done using it rather than leaving it up to garbage collection or it seems they can keep piling up... There are two instances where close is never called: 1) Getting Java version 2) Getting Java PID ** patch forthcoming
Created attachment 612647 [details] fixes connection leak patch
Tried applying the patch - it failed on current master (which is 6887631b) - please correct and re-attach to this BZ. Here's the error I get: $ git am ~/Downloads/0001-Bug-848938-JMX-Plugin-Leaking-connector-thread.patch Applying: Bug 848938 - JMX Plugin - Leaking connector thread error: patch failed: modules/plugins/jmx/src/main/java/org/rhq/plugins/jmx/JMXDiscoveryComponent.java:335 error: modules/plugins/jmx/src/main/java/org/rhq/plugins/jmx/JMXDiscoveryComponent.java: patch does not apply Patch failed at 0001 Bug 848938 - JMX Plugin - Leaking connector thread
Created attachment 614447 [details] updated patch against master - 9f175839392
git commit to master: 26b37482f90fb01a6771c5c51471e2754dc3cdb4
Set Target Release correctly.
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.