Red Hat Bugzilla – Bug 848958
Review Request : gmchess - Chinese Chess Game
Last modified: 2013-06-11 05:22:40 EDT
Spec URL: http://py.luyten.fr/Publique/Fedora/gmchess.spec
SRPM URL: http://py.luyten.fr/Publique/Fedora/gmchess-0.29.6-0.1.fc17.src.rpm
Description: GPL v2 Chiness Chess (Xiangqi) game, including AI. Gtk 2 / C++ .
Fedora Account System Username: pyluyten
This package needs a sponsor, this is my first.
Some initial comments:
* No use macro in changelog
* No explicit library requires
* Just use:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
* The URL should be the project homepage, not the author's blog.
* Upstream seems not well maintained.
"No explicit library requires" : I kept only gtkmm24-devel inside BuildRequires, unless you meant something else.
URL changed, changelog macro removed.
"Upstream seems not well maintained" : actually I would like to have a look to this code , but this might require some time and first, a package would be nice.
Using %post -p /sbin/ldconfig as recommended, i get below errors on RPM, thus I'll investigate further.
gmchess.x86_64: E: postun-without-ldconfig /usr/lib64/libeval.so.0.0.0
gmchess.x86_64: E: non-empty-%postun /sbin/ldconfig
However I pushed the new spec and srpm.
Spec : http://py.luyten.fr/Publique/Fedora/gmchess/gmchess.spec
Srpm : http://py.luyten.fr/Publique/Fedora/gmchess/gmchess-0.29.6-0.1.fc17.src.rpm
I did add one EOL after postun to reduce issues to below warning
gmchess.x86_64: W: percent-in-%postun
I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.
This package fails to build for me; here is a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5489154
Shockingly, libeval.so doesn't appear to conflict with anything else in the distribution. It's still an amazingly generic name for something which appears to have no use outside of this program, and renaming it wouldn't be a bad idea.
Thanks for this triaging
gmchess had not release at all since I started the package ; I've upstreamed the libeval.so issue just in case but i'm closing ticket.