Bug 849192

+++ This bug was initially created as a clone of Bug #848800 +++

Description of problem:


jopr-jboss-as-5-plugin-4.4.0.JON311-SNAPSHOT.signature-check.xml

<?xml version="1.0"?>
<diffreport>
  <difference binseverity="ERROR" srcseverity="ERROR" 
class="org.rhq.plugins.jbossas5.Ejb2BeanComponent" method="protected 
org.jboss.managed.api.ManagedComponent getManagedComponent()">In method 
'protected org.jboss.managed.api.ManagedComponent getManagedComponent()' the 
number of arguments has changed</difference>
  <difference binseverity="ERROR" srcseverity="ERROR" 
class="org.rhq.plugins.jbossas5.helper.CreateChildResourceFacetDelegate" 
method="public 
CreateChildResourceFacetDelegate(org.rhq.plugins.jbossas5.ProfileServiceComponent)">In 
method 'public 
CreateChildResourceFacetDelegate(org.rhq.plugins.jbossas5.ProfileServiceComponent)' 
the number of arguments has changed</difference>
</diffreport>

These should be fixed just in case the plugins that depend on AS5 plugin use
these methods.

--- Additional comment from snegrea on 2012-08-17 09:50:03 EDT ---

<difference binseverity="ERROR" srcseverity="ERROR" 
class="org.rhq.plugins.jbossas5.Ejb2BeanComponent" method="protected 
org.jboss.managed.api.ManagedComponent getManagedComponent()">In method 
'protected org.jboss.managed.api.ManagedComponent getManagedComponent()' the 
number of arguments has changed</difference>

This difference is due to fixes applied for bug 835113. The old method signature cannot be added back because it would re-introduce the problem fixed by bug 835113. 

This method is just protected so it is not visible (or available for use) outside of inheriting classes. Also, this method is just an override for a base method from ManagedComponentComponent. The base class, ManagedComponentComponent, still has both methods available for use. The fix for bug 835113 had the Ejb2BeanComponent override a different base method. 


Based on this, no action to be taken for this difference.

--- Additional comment from snegrea on 2012-08-17 12:16:02 EDT ---

<difference binseverity="ERROR" srcseverity="ERROR" 
class="org.rhq.plugins.jbossas5.helper.CreateChildResourceFacetDelegate" 
method="public CreateChildResourceFacetDelegate(org.rhq.plugins.jbossas5.ProfileServiceComponent)">In method 'public CreateChildResourceFacetDelegate(org.rhq.plugins.jbossas5.ProfileServiceComponent)' the number of arguments has changed</difference>

Added back the old constructor and marked it as deprecated. The old constructor is not used by RHQ code. If external plugins make use of this constructor, the only downside is the SHA256 computation for exploded content. The SHA256 will not be calculated based on the unexploded content but rather on the exploded files on disk. And this calculation will be done by the content discovery process rather than the deployment process (done in normal circumstances).