Bug 849268 - Missing dependency on nm-connection-editor
Summary: Missing dependency on nm-connection-editor
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: control-center
Version: 18
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Control Center Maintainer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-17 22:36 UTC by Adam Williamson
Modified: 2012-09-27 00:12 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 862835 (view as bug list)
Environment:
Last Closed: 2012-09-27 00:12:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2012-08-17 22:36:38 UTC
control-center's Network panel calls nm-connection-editor to edit certain types of connections (I think wireless connections and VPNs):

panels/network/cc-network-panel.c:                cmdline = g_strdup_printf ("nm-connection-editor --create --type %s", type);
panels/network/cc-network-panel.c:                        g_warning ("Failed to launch nm-connection-editor: %s", error->message);
panels/network/net-vpn.c:        cmdline = g_strdup_printf ("nm-connection-editor --edit %s", uuid);
panels/network/net-vpn.c:                g_warning ("Failed to launch nm-connection-editor: %s", error->message);
panels/network/net-device.c:        cmdline = g_strdup_printf ("nm-connection-editor --edit %s", uuid);
panels/network/net-device.c:                g_warning ("Failed to launch nm-connection-editor: %s", error->message);

but our control-center package has no dependency on nm-connection-editor. If you try and configure a VPN connection without it installed, you just get zero feedback (the 'Failed to launch' message is printed only to the console if you ran from a console, I think, there's no graphical error).

Comment 1 Debarshi Ray 2012-08-17 22:46:14 UTC
commit 9d38f9b3b28fed4251fe45eac87917d2dda0b26d
Author: Debarshi Ray <debarshir>
Date:   Sat Aug 18 00:45:33 2012 +0200

    Add Requires: nm-connection-editor (RH #849268)


Note You need to log in before you can comment on or make changes to this bug.