Bug 849380 - Review Request: python-carbon - Back-end data caching and persistence daemon for Graphite
Summary: Review Request: python-carbon - Back-end data caching and persistence daemon ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mario Blättermann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 824348 842301 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-18 23:20 UTC by Jonathan Steffan
Modified: 2014-09-29 19:55 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-09 19:27:29 UTC
Type: ---
Embargoed:
mario.blaettermann: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jonathan Steffan 2012-08-18 23:20:48 UTC
Spec URL: http://jsteffan.fedorapeople.org/SPECS/python-carbon.spec
SRPM URL: http://jsteffan.fedorapeople.org/SRPMS/python-carbon-0.9.10-1.fc17.src.rpm
Description:
Twisted daemon that listens for time-series data and writes this data
out to whisper databases, relays the data or aggregates the data.
Carbon is a data collection and storage agent.

Fedora Account System Username: jsteffan

Comment 1 Mario Blättermann 2012-08-23 09:36:45 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4416584

$ rpmlint -i -v *
python-carbon.src: I: checking
python-carbon.src: I: checking-url https://launchpad.net/graphite/ (timeout 10 seconds)
python-carbon.src: I: checking-url https://github.com/downloads/graphite-project/carbon/carbon-0.9.10.tar.gz (timeout 10 seconds)
python-carbon.noarch: I: checking
python-carbon.noarch: I: checking-url https://launchpad.net/graphite/ (timeout 10 seconds)
python-carbon.noarch: W: non-standard-uid /var/lib/carbon/lists carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/lib/carbon/lists carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: W: non-standard-uid /var/lib/carbon carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/lib/carbon carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: W: non-standard-uid /var/log/carbon carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/log/carbon carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/carbon/amqp_listener.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-carbon.noarch: W: non-standard-uid /var/lib/carbon/rrd carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/lib/carbon/rrd carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: W: non-standard-uid /var/lib/carbon/whisper carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/lib/carbon/whisper carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/carbon/amqp_publisher.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-carbon.noarch: W: log-files-without-logrotate /var/log/carbon
This package contains files in /var/log/ without adding logrotate
configuration for them.

python-carbon.noarch: W: no-manual-page-for-binary carbon-client
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: no-manual-page-for-binary carbon-aggregator
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: no-manual-page-for-binary carbon-cache
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: no-manual-page-for-binary validate-storage-schemas
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: no-manual-page-for-binary carbon-relay
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: dangerous-command-in-%postun userdel
python-carbon.noarch: W: no-reload-entry /etc/init.d/carbon-cache
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

python-carbon.noarch: W: no-reload-entry /etc/init.d/carbon-relay
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

python-carbon.noarch: W: no-reload-entry /etc/init.d/carbon-aggregator
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

python-carbon.spec: I: checking-url https://github.com/downloads/graphite-project/carbon/carbon-0.9.10.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 2 errors, 20 warnings.


Issues regarding non standard users like in python-bucky (bug #849382), no problem. Furthermore missing man pages, which is not up to you. Just a few recognizable issues:

python-carbon.noarch: W: no-reload-entry /etc/init.d/carbon-relay
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

Is this needed here? Or does python-carbon solve this reloading in another way? 


python-carbon.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/carbon/amqp_publisher.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

Usually, the scripts in %{python_sitelib} don't have to be executable... Don't know what the problem is. Either remove the shebang or set the executable bit, or is there another solution?

Comment 2 Mario Blättermann 2012-09-15 19:18:57 UTC
Any news...?

Comment 3 Jonathan Steffan 2012-09-16 19:45:16 UTC
The spec and srpm has been updated to address the following issues:

python-carbon.noarch: W: no-reload-entry /etc/init.d/carbon-relay
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

python-carbon.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/carbon/amqp_publisher.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

Spec URL: http://jsteffan.fedorapeople.org/SPECS/python-carbon.spec
SRPM URL: http://jsteffan.fedorapeople.org/SRPMS/python-carbon-0.9.10-1.fc17.src.rpm

Comment 4 Mario Blättermann 2012-09-20 20:52:58 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4508973

$ rpmlint -i -v *
python-carbon.src: I: checking
python-carbon.src: I: checking-url https://launchpad.net/graphite/ (timeout 10 seconds)
python-carbon.src: I: checking-url https://github.com/downloads/graphite-project/carbon/carbon-0.9.10.tar.gz (timeout 10 seconds)
python-carbon.noarch: I: checking
python-carbon.noarch: I: checking-url https://launchpad.net/graphite/ (timeout 10 seconds)
python-carbon.noarch: W: non-standard-uid /var/lib/carbon/lists carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/lib/carbon/lists carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: W: non-standard-uid /var/lib/carbon carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/lib/carbon carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: W: non-standard-uid /var/log/carbon carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/log/carbon carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: W: non-standard-uid /var/lib/carbon/rrd carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/lib/carbon/rrd carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: W: non-standard-uid /var/lib/carbon/whisper carbon
A file in this package is owned by a non standard user. Standard users are:
abrt, adm, aeolus, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd,
bacula, beagleindex, bin, cimsrvr, clamav, condor, cyrus, daemon, dbus,
desktop, dhcpd, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm,
glance, gopher, haldaemon, halt, hsqldb, ident, jonas, keystone, ldap, lp,
luci, mail, mailman, mailnull, majordomo, myproxy, mysql, named, netdump,
news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator,
oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres,
prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quantum, radiusd,
radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit,
sabayon, saned, sanlock, shutdown, smmsp, snortd, squid, sshd, stap-server,
swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd,
wallaby, webalizer, wnn, xfs.

python-carbon.noarch: W: non-standard-gid /var/lib/carbon/whisper carbon
A file in this package is owned by a non standard group. Standard groups are:
abrt, adm, aeolus, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula,
beagleindex, bin, cdrom, cimsrvr, clamav, condor, console, daemon, dbus,
desktop, dhcpd, dialout, dip, disk, distcache, dovecot, exim, fax, floppy,
frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas,
keystone, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo,
man, mem, myproxy, mysql, named, netdump, news, nfsnobody, nobody, nocpulse,
nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser,
popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy,
pulse, puppet, pvm, qemu, quagga, quaggavt, quantum, radiusd, radvd, realtime,
retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon,
saned, sanlock, saslauth, screen, slipusers, slocate, smmsp, snortd, squid,
sshd, stap-server, stapdev, stapsys, stapusr, swift, sys, tape, tcpdump,
tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video,
wallaby, wbpriv, webalizer, wheel, wine, wnn, xfs.

python-carbon.noarch: W: log-files-without-logrotate /var/log/carbon
This package contains files in /var/log/ without adding logrotate
configuration for them.

python-carbon.noarch: W: no-manual-page-for-binary carbon-client
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: no-manual-page-for-binary carbon-aggregator
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: no-manual-page-for-binary carbon-cache
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: no-manual-page-for-binary validate-storage-schemas
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: no-manual-page-for-binary carbon-relay
Each executable in standard binary directories should have a man page.

python-carbon.noarch: W: dangerous-command-in-%postun userdel
python-carbon.spec: I: checking-url https://github.com/downloads/graphite-project/carbon/carbon-0.9.10.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 17 warnings.


The folder /var/log/carbon doesn't contain any files initially, that's why the warning is false positive. No further objections, as already discussed earlier.


---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual license.
    ASL 2.0
[+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
    $ sha256sum *
    4f37e00595b5b078edb9b3f5cae318f752f4446a82623ea4da97dd7d0f6a5072  carbon-0.9.10.tar.gz
    4f37e00595b5b078edb9b3f5cae318f752f4446a82623ea4da97dd7d0f6a5072  carbon-0.9.10.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[.] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
[.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses Mock anyway).
[+] SHOULD: The package should compile and build into binary rpms on all supported architectures.
[.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.
[.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.

----------------

PACKAGE APPROVED

----------------

Comment 5 Jonathan Steffan 2012-09-26 20:34:02 UTC
New Package SCM Request
=======================
Package Name: python-carbon
Short Description: Back-end data caching and persistence daemon for Graphite
Owners: jsteffan
Branches: f16 f17 f18 el5 el6
InitialCC:

Comment 6 Gwyn Ciesla 2012-09-27 11:23:03 UTC
Git done (by process-git-requests).

Comment 7 Mario Blättermann 2012-10-18 19:32:21 UTC
No packages built yet...?

Comment 8 Mario Blättermann 2012-11-01 20:40:00 UTC
Just a reminder...

Comment 9 Mario Blättermann 2012-11-15 10:15:39 UTC
Another reminder...

Comment 10 Jonathan Steffan 2012-11-25 00:06:31 UTC
*** Bug 824348 has been marked as a duplicate of this bug. ***

Comment 11 Jonathan Steffan 2012-11-25 00:06:51 UTC
*** Bug 842301 has been marked as a duplicate of this bug. ***

Comment 12 Jonathan Steffan 2012-11-25 00:25:14 UTC
Mario,

Packages are now built and updates requests filed. I'll fix the el5 build issues shortly.

Comment 14 Jonathan Steffan 2012-12-09 19:27:29 UTC
These updates have been marked as stable.

Comment 15 Jonathan Steffan 2014-09-28 22:30:38 UTC
Package Change Request
======================
Package Name: python-carbon
New Branches: epel7
Owners: jsteffan

Comment 16 Gwyn Ciesla 2014-09-29 12:03:44 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.