Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 849422

Summary: ovirt-engine-backend [TEXT]: wrong error message when trying to add shared tag to disk created from template as thin provision
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: ovirt-engineAssignee: Ayal Baron <abaron>
Status: CLOSED WONTFIX QA Contact: Haim <hateya>
Severity: medium Docs Contact:
Priority: high    
Version: unspecifiedCC: amureini, dyasny, hateya, iheim, lpeer, Rhev-m-bugs, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.1.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-25 07:25:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
log none

Description Dafna Ron 2012-08-19 11:38:08 UTC
Created attachment 605473 [details]
log

Description of problem:

since a vm created from template as thin provision is actually a snapshot of the template we are getting a wrong error message when trying to add the shared tag to the disk: 

Error while executing action: Cannot edit Virtual Machine Disk. Disk cannot be shareable if it depends on a snapshot. In order to share it, remove the disk's snapshots.

Version-Release number of selected component (if applicable):

si14

How reproducible:

100%

Steps to Reproduce:
1. create a vm from template as thin provision copy
2. try to add shared tag to the disk
3.
  
Actual results:

we are getting the following error: 

Error while executing action: Cannot edit Virtual Machine Disk. Disk cannot be shareable if it depends on a snapshot. In order to share it, remove the disk's snapshots.

Expected results:

since the vm disk itself is the snapshot if we remove it we will have no disk. 

Additional info:

Comment 1 Ayal Baron 2012-08-19 20:48:09 UTC
(In reply to comment #0)
> Created attachment 605473 [details]
> log
> 
> Description of problem:
> 
> since a vm created from template as thin provision is actually a snapshot of
> the template we are getting a wrong error message when trying to add the
> shared tag to the disk: 
> 
> Error while executing action: Cannot edit Virtual Machine Disk. Disk cannot
> be shareable if it depends on a snapshot. In order to share it, remove the
> disk's snapshots.
> 
> Version-Release number of selected component (if applicable):
> 
> si14
> 
> How reproducible:
> 
> 100%
> 
> Steps to Reproduce:
> 1. create a vm from template as thin provision copy
> 2. try to add shared tag to the disk
> 3.
>   
> Actual results:
> 
> we are getting the following error: 
> 
> Error while executing action: Cannot edit Virtual Machine Disk. Disk cannot
> be shareable if it depends on a snapshot. In order to share it, remove the
> disk's snapshots.
> 
> Expected results:
> 
> since the vm disk itself is the snapshot if we remove it we will have no
> disk. 

It is not a snapshot, the backing file (the template) is the snapshot.
The disk is mutable, snapshots are immutable.

At most, we can add 'snapshot/template' for clarity.

Comment 2 Dafna Ron 2012-08-20 07:35:26 UTC
Ayal, this is not correct. 
the vm's disk is created as a snapshot of the template. the actual image is the template's image not the disk (and you can create several vm's linked to the same template's image.  
also you cannot remove the template as long as it has vm's that are linked to it. 
changing the error to "snapshot/template" would be incorrect since the user cannot remove the template without removing the vm first.

Comment 3 Itamar Heim 2013-02-25 07:25:02 UTC
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.