Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 849443

Summary: webadmin: we do not check PCI limit on VMs when attaching disks
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: ovirt-engine-webadmin-portalAssignee: Daniel Erez <derez>
Status: CLOSED CURRENTRELEASE QA Contact: Omri Hochman <ohochman>
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: amureini, dyasny, ecohen, hateya, iheim, lpeer, ofrenkel, Rhev-m-bugs, sgrinber, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.1.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: si16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-04 20:07:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
log none

Description Dafna Ron 2012-08-19 13:38:34 UTC
Created attachment 605490 [details]
log

Description of problem:

I can attach more than 3 IDE disks and more than 24 virtIO disks when attaching disks. 

Version-Release number of selected component (if applicable):

si14

How reproducible:

100%

Steps to Reproduce:
1. create 4 IDE disks or 30 virtIO disks 
2. select and attach the all the disks to a vm 
3.
  
Actual results:

we can attach more than 3 IDE disks and more than 24 virtIO disks

Expected results:

we should fail to attach more than 3 IDE disks and more than 24 virtIO disks

Additional info: engine log

Comment 1 Omer Frenkel 2012-08-26 08:42:54 UTC
problem is that the limit is checked in canDoAction,
when enabling user to select multiple disks to attach, and using runMultipleAction, canDoAction pass for all disk without taking into consideration other disks.

moving to frontend so runMultipleAction will not be used for this action.

Comment 2 Daniel Erez 2012-08-27 13:17:48 UTC
patch sent upstream:
http://gerrit.ovirt.org/#/c/7503/

Comment 3 Allon Mureinik 2012-08-27 14:00:00 UTC
merged Change-Id: Ic771ef86926c471ed46524c77a0fdfafc00c63cf

Comment 4 Omri Hochman 2012-11-05 11:03:09 UTC
Verified RHEVM Build SI23.

**********************************
- When attempted to attach (at once) 4 IDE HD's --> Only 3 HD's were actually attached.

The following gui error displayed: 
-----------------------------------
"Error:
spice_desktop:

    Cannot attach Virtual Machine Disk. Maximum IDE devices exceeded" 

**********************************

- When attempted to attach (at once) 4 VirtIO HD's --> Only 3 HD's were actually attached.

The following gui error displayed: 
----------------------------------

"Error:

spice_desktop:

    Cannot attach Virtual Machine Disk. Maximum PCI devices exceeded. "