I am triaging old review tickets.  I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.

Ths package fails to build for me.  Here's a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5505769

I suspect it needs some updating to meet current Java packaging guidelines.  For example, the javadoc subpackage is mandatory.  I'm no Java expert, though.

Created attachment 761917 [details]
rawhide build log for webbit-0.4.15-1 with test failure

I've updated the package:

http://fedorapeople.org/~dcallagh/webbit/webbit.spec
http://fedorapeople.org/~dcallagh/webbit/webbit-0.4.15-1.fc18.src.rpm

I believe it meets all guidelines now, however the build is failing in Rawhide for me because of a test failure. It seems to be related to the newer netty version in F19/Rawhide (I don't see the test failure in F18). If anyone has any ideas what's going wrong here I'd appreciate some help...

excuse me, which version of Fedora you want to use this package?
regards

(In reply to gil cattaneo from comment #3)
> excuse me, which version of Fedora you want to use this package?

I'm not sure I understand the question... I was planning to build this for all current Fedora releases (F18 and newer I suppose, since F17 is almost EOL).

But I still haven't had a chance to look into the test failures related to netty from comment 2.

I filed an upstream issue about this test failure in rawhide:

https://github.com/webbit/webbit/issues/121

The master branch of webbit is using netty 3.6.5 but it breaks with netty 3.6.6 (in rawhide). Neither I nor the webbit author could figure out why.

please, these BRs must be removed are alredy requred by "java tools"
BuildRequires:  jpackage-utils
BuildRequires:  maven-compiler-plugin
BuildRequires:  maven-install-plugin
BuildRequires:  maven-jar-plugin
BuildRequires:  maven-javadoc-plugin
BuildRequires:  maven-resources-plugin
BuildRequires:  maven-surefire-plugin

also these for the same reason
Requires:       java
Requires:       jpackage-utils

if you want install in /usr/share/java instead of /usr/share/java/webbit
you can use
%mvn_file org.webbitserver:%{name} %{name}
OR
%mvn_file :%{name} %{name}
OR
%mvn_file : %{name}
this is possible only for those package which provides artifacts <= 2
regards

This is an automatic action taken by review-stats script.

The submitter account doesn't exist anymore, therefore this ticket will be closed.