Spec URL: http://bochecha.fedorapeople.org/packages/perl-Algorithm-NaiveBayes.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Algorithm-NaiveBayes-0.04-1.fc18.src.rpm Description: This module implements the classic "Naive Bayes" machine learning algorithm. It is a well-studied probabilistic algorithm often used in automatic text categorization. Compared to other algorithms (kNN, SVM, Decision Trees), it's pretty fast and reasonably competitive in the quality of its results. Fedora Account System Username: bochecha
There is no license file shipped by the module, and not all file have a license, could you ask upstream about it ( ie, at least ship a license file, and maybe add a note about each file to avoid problem.
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated Issues: ======= [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr macros not found. They would be needed for EPEL5 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [-]: Large documentation files are in a -doc subpackage, if required. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: No description for test named CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL5 is required [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [-]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (Algorithm-NaiveBayes-0.04.tar.gz) [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: perl-Algorithm-NaiveBayes-0.04-1.fc17.noarch.rpm perl-Algorithm-NaiveBayes-0.04-1.fc17.src.rpm perl-Algorithm-NaiveBayes.noarch: W: spelling-error %description -l en_US kNN -> kn N, CNN, kn perl-Algorithm-NaiveBayes.src: W: spelling-error %description -l en_US kNN -> kn N, CNN, kn 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint perl-Algorithm-NaiveBayes perl-Algorithm-NaiveBayes.noarch: W: spelling-error %description -l en_US kNN -> kn N, CNN, kn 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- perl-Algorithm-NaiveBayes-0.04-1.fc17.noarch.rpm (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.14.2) perl(Algorithm::NaiveBayes) perl(Algorithm::NaiveBayes::Util) perl(Exporter) perl(List::Util) perl(Storable) perl(base) perl(constant) perl(strict) perl(vars) Provides -------- perl-Algorithm-NaiveBayes-0.04-1.fc17.noarch.rpm: perl(Algorithm::NaiveBayes) = 0.04 perl(Algorithm::NaiveBayes::Model::Discrete) perl(Algorithm::NaiveBayes::Model::Frequency) perl(Algorithm::NaiveBayes::Model::Gaussian) perl(Algorithm::NaiveBayes::Util) perl-Algorithm-NaiveBayes = 0.04-1.fc17 MD5-sum check ------------- http://www.cpan.org/authors/id/K/KW/KWILLIAMS/Algorithm-NaiveBayes-0.04.tar.gz : CHECKSUM(SHA256) this package : fd769448ec977a3626a135b02e0d5fcd41de2d9d14ade0632194d1ad801eeccd CHECKSUM(SHA256) upstream package : fd769448ec977a3626a135b02e0d5fcd41de2d9d14ade0632194d1ad801eeccd Generated by fedora-review 0.2.0 (a5c4ced) last change: 2012-07-22 Command line :./try-fedora-review -b 849545
It's Fedora perl-modules' packaging convention to let perl-modules own all directories below %{perl_vendorlib}. This packages misses to own %{perl_vendorlib/Algorithm (MUSTFIX): # rpm -qlvp /var/lib/mock/fedora-rawhide-x86_64/result/perl-Algorithm-NaiveBayes-0.04-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Sep 3 07:17 /usr/share/doc/perl-Algorithm-NaiveBayes-0.04 -rw-r--r-- 1 root root 1429 Jun 8 2007 /usr/share/doc/perl-Algorithm-NaiveBayes-0.04/Changes -rw-r--r-- 1 root root 4759 Sep 3 07:17 /usr/share/man/man3/Algorithm::NaiveBayes.3pm.gz drwxr-xr-x 2 root root 0 Sep 3 07:17 /usr/share/perl5/vendor_perl/Algorithm/NaiveBayes -rw-r--r-- 1 root root 8903 Sep 3 07:17 /usr/share/perl5/vendor_perl/Algorithm/NaiveBayes.pm drwxr-xr-x 2 root root 0 Sep 3 07:17 /usr/share/perl5/vendor_perl/Algorithm/NaiveBayes/Model -rw-r--r-- 1 root root 1560 Sep 3 07:17 /usr/share/perl5/vendor_perl/Algorithm/NaiveBayes/Model/Discrete.pm -rw-r--r-- 1 root root 2338 Sep 3 07:17 /usr/share/perl5/vendor_perl/Algorithm/NaiveBayes/Model/Frequency.pm -rw-r--r-- 1 root root 1720 Sep 3 07:17 /usr/share/perl5/vendor_perl/Algorithm/NaiveBayes/Model/Gaussian.pm -rw-r--r-- 1 root root 933 Sep 3 07:17 /usr/share/perl5/vendor_perl/Algorithm/NaiveBayes/Util.pm
Thanks for the comments, this should address both issues. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Algorithm-NaiveBayes.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Algorithm-NaiveBayes-0.04-2.fc18.src.rpm
Seems to be good, approved.
New Package SCM Request ======================= Package Name: perl-Algorithm-NaiveBayes Short Description: Bayesian prediction of categories Owners: bochecha Branches: devel InitialCC: perl-sig
Git done (by process-git-requests).
Thanks Jon! Package built in Rawhide, closing.