Bug 849907 - [engine] ReconstructMasterDomain fails when master domain is unblocked
[engine] ReconstructMasterDomain fails when master domain is unblocked
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine (Show other bugs)
All Unspecified
unspecified Severity high
: ---
: 3.1.0
Assigned To: Liron Aravot
Gadi Ickowicz
Depends On:
  Show dependency treegraph
Reported: 2012-08-21 04:09 EDT by Gadi Ickowicz
Modified: 2016-02-10 15:23 EST (History)
10 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-09-09 07:31:26 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: Storage
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
engine + vdsm logs (15.89 MB, application/x-tar)
2012-08-21 04:09 EDT, Gadi Ickowicz
no flags Details

  None (edit)
Description Gadi Ickowicz 2012-08-21 04:09:24 EDT
Created attachment 605877 [details]
engine + vdsm logs

Description of problem:
After the master domain is blocked (using IPtables) and then unblocked, ReconstructMasterDomain fails repeatedly. Only manually activating the domain resolves the problem

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
using automated test with the following scenario:
1. One host, 1 iscsi data domain, 1 ISO domain
2. Block connection from host to data domain
3. unblock connection from host to data domain   
Actual results:
domain does not become active again until ActivateDataDomain is manually sent

Expected results:
Domain should reactivate when connection is unblocked

Additional info:
logs attached
Comment 1 Allon Mureinik 2012-08-27 05:15:10 EDT
HandleFailedStorageDomainCommand calls ReconstructMasterDomainCommand which calls ConnectStoragePool and RefreshStoragePool, which should fail if the storage server isn't connected.

Manual activation calls (eventually) ConnectStorageServer (in org.ovirt.engine.core.bll.storage.ISCSIStorageHelper.RunConnectionStorageToDomain(storage_domains, Guid, int, LUNs, Guid)), and thus succeeds.

Since there currectly is no connection management in VDSM, I'm guessing the best solution is the to have ConnectStoragePool also imply a call to ConnectStorageServer.
If the server is already connected, VDSM will just silently ignore it.
Comment 2 Allon Mureinik 2012-08-27 05:56:08 EDT
added Liron as QA contact instead of assignee by mistake.
Comment 3 Gadi Ickowicz 2012-09-09 07:31:26 EDT
Ran the automated scenario on SI17 - does not reproduce the problem

Note You need to log in before you can comment on or make changes to this bug.