Bug 850489 - Review Request: ghc-HSH - Haskell HSH library
Review Request: ghc-HSH - Haskell HSH library
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Narasimhan
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2012-08-21 12:32 EDT by Shakthi Kannan
Modified: 2012-09-17 19:46 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-09-17 13:48:10 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lakshminaras2002: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Shakthi Kannan 2012-08-21 12:32:18 EDT
Spec URL: http://shakthimaan.fedorapeople.org/SPECS/ghc-HSH.spec
SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/ghc-HSH-2.0.4-1.fc16.src.rpm
Description: Haskell HSH library
Fedora Account System Username: shakthimaan
Comment 1 Shakthi Kannan 2012-08-21 12:34:27 EDT
$  rpmlint ghc-HSH.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$  rpmlint ghc-HSH-2.0.4-1.fc16.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$  rpmlint ghc-HSH-2.0.4-1.fc16.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$  rpmlint ghc-HSH-devel-2.0.4-1.fc16.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Successful Koji builds for F16, F17, and F18 respectively:

Comment 2 Narasimhan 2012-09-07 05:38:22 EDT
[+]MUST: rpmlint must be run on every package. The output should be posted in the review.
rpmlint  -i ghc-HSH-2.0.4-1.fc17.src.rpm  ghc-HSH-2.0.4-1.fc17.x86_64.rpm ghc-HSH-devel-2.0.4-1.fc17.x86_64.rpm ../ghc-HSH.spec 
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Version-release - Matches
        License - OK
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK, in devel package.

[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
COPYING file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
 sha256sum HSH-2.0.4.tar.gz ghc-HSH-2.0.4-1.fc16.src/HSH-2.0.4.tar.gz 
68a3556e722d91aa2240f3c9c95fa351116af7d138e6d03034e10834eb57b7b5  HSH-2.0.4.tar.gz
68a3556e722d91aa2240f3c9c95fa351116af7d138e6d03034e10834eb57b7b5  ghc-HSH-2.0.4-1.fc16.src/HSH-2.0.4.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Built on x86_64. Links for koji builds on x86 and x86_64 in the review request.
[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
API documentation in -devel package.
[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[NA]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}
[+]MUST: Packages must not own files or directories already owned by other packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[-]SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. 
[-]SHOULD: The reviewer should test that the package builds in mock. 
[-]SHOULD: The package should compile and build into binary rpms on all supported architectures.
[+]SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
Imported HSH.Command into ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.

cabal2spec-diff is OK.

Comment 3 Narasimhan 2012-09-07 05:42:58 EDT
Please provide a different summary for the package.
Comment 4 Shakthi Kannan 2012-09-07 05:48:41 EDT
Thanks for the review. Will update the summary before import.

New Package SCM Request
Package Name: ghc-HSH
Short Description: Allows to mix shell expressions with Haskell programs
Owners: shakthimaan
Branches: f16 f17 f18
InitialCC: haskell-sig
Comment 5 Gwyn Ciesla 2012-09-07 05:52:49 EDT
Git done (by process-git-requests).
Comment 6 Fedora Update System 2012-09-07 06:35:28 EDT
ghc-HSH-2.0.4-2.fc17 has been submitted as an update for Fedora 17.
Comment 7 Fedora Update System 2012-09-07 06:35:39 EDT
ghc-HSH-2.0.4-2.fc16 has been submitted as an update for Fedora 16.
Comment 8 Fedora Update System 2012-09-07 06:35:48 EDT
ghc-HSH-2.0.4-2.fc18 has been submitted as an update for Fedora 18.
Comment 9 Fedora Update System 2012-09-07 15:39:14 EDT
ghc-HSH-2.0.4-2.fc18 has been pushed to the Fedora 18 testing repository.
Comment 10 Fedora Update System 2012-09-17 13:48:10 EDT
ghc-HSH-2.0.4-2.fc16 has been pushed to the Fedora 16 stable repository.
Comment 11 Fedora Update System 2012-09-17 13:50:39 EDT
ghc-HSH-2.0.4-2.fc17 has been pushed to the Fedora 17 stable repository.
Comment 12 Fedora Update System 2012-09-17 19:46:02 EDT
ghc-HSH-2.0.4-2.fc18 has been pushed to the Fedora 18 stable repository.

Note You need to log in before you can comment on or make changes to this bug.