Spec URL: http://fedorapeople.org/~grover/new/python-tlslite.spec SRPM URL: http://fedorapeople.org/~grover/new/python-tlslite-0.4.1-1.fc17.src.rpm Description: TLS Lite is an open source Python library that implements SSL and TLS. TLS Lite supports RSA and SRP cipher suites. TLS Lite is pure Python, however it can use other libraries for faster crypto operations. TLS Lite integrates with several stdlib networking libraries. Fedora Account System Username: grover
rpmlint complains because tls.py and tlsdb.py don't have manpages. These are test scripts. Should I leave them in _bindir w/o manpages, or maybe put them in _docdir?
> Package Review > ============== > > Key: > - = N/A > x = Pass > ! = Fail > ? = Not evaluated > > > > ==== Generic ==== > [x]: EXTRA Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: EXTRA Spec file according to URL is the same as in SRPM. > [ ]: MUST Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [x]: MUST Package successfully compiles and builds into binary rpms on at > least one supported primary architecture. > [ ]: MUST %build honors applicable compiler flags or justifies otherwise. > [x]: MUST All build dependencies are listed in BuildRequires, except for any > that are listed in the exceptions section of Packaging Guidelines. > [ ]: MUST Package contains no bundled libraries. > [ ]: MUST Changelog in prescribed format. > [ ]: MUST Sources contain only permissible code or content. > [x]: MUST Each %files section contains %defattr if rpm < 4.4 > Note: Note: defattr macros not found. They would be needed for EPEL5 > [ ]: MUST Macros in Summary, %description expandable at SRPM build time. > [ ]: MUST Package contains desktop file if it is a GUI application. > [ ]: MUST Development files must be in a -devel package > [ ]: MUST Package requires other packages for directories it uses. > [ ]: MUST Package uses nothing in %doc for runtime. > [ ]: MUST Package is not known to require ExcludeArch. > [x]: MUST Permissions on files are set properly. > [x]: MUST Package does not contain duplicates in %files. > [ ]: MUST Package complies to the Packaging Guidelines > [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. > [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > Note: rm -rf would be needed if support for EPEL5 is required > [ ]: MUST Large documentation files are in a -doc subpackage, if required. > [x]: MUST If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %doc. > [!]: MUST License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. No licenses > found. Please check the source files for licenses manually. I do not see anything in the source that contradicts the LICENSE file. > [ ]: MUST Package consistently uses macro is (instead of hard-coded directory > names). > [x]: MUST Package is named using only allowed ascii characters. > [ ]: MUST Package is named according to the Package Naming Guidelines. > [ ]: MUST Package does not generate any conflict. > Note: Package contains no Conflicts: tag(s) > [ ]: MUST Package obeys FHS, except libexecdir and /usr/target. > [ ]: MUST If the package is a rename of another package, proper Obsoletes and > Provides are present. > [ ]: MUST Package must own all directories that it creates. > [ ]: MUST Package does not own files or directories owned by other packages. > [x]: MUST Package installs properly. > [ ]: MUST Package is not relocatable. > [ ]: MUST Requires correct, justified where necessary. > [x]: MUST Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). > [x]: MUST Sources used to build the package match the upstream source, as > provided in the spec URL. > [ ]: MUST Spec file is legible and written in American English. > [x]: MUST Spec file name must match the spec package %{name}, in the format > %{name}.spec. > [ ]: MUST Package contains systemd file(s) if in need. > [x]: MUST File names are valid UTF-8. > [x]: SHOULD Reviewer should test that the package builds in mock. > [x]: SHOULD Buildroot is not present > Note: Unless packager wants to package for EPEL5 this is fine > [x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: Clean would be needed if support for EPEL5 is required > [ ]: SHOULD If the source package does not include license text(s) as a > separate file from upstream, the packager SHOULD query upstream to > include it. > [x]: SHOULD Dist tag is present. > [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, > /usr/sbin. > [ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q > --requires). > [ ]: SHOULD Package functions as described. > [ ]: SHOULD Latest version is packaged. > [ ]: SHOULD Package does not include license text files separate from > upstream. > [x]: SHOULD SourceX tarball generation or download is documented. > [!]: SHOULD SourceX / PatchY prefixed with %{name}. > Note: Source0 (tlslite-0.4.1.tar.gz) Package name differs from tarball only by python- prefix, as compliant with packaging guidelines. > [x]: SHOULD SourceX is a working URL. > [ ]: SHOULD Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. > [ ]: SHOULD Package should compile and build into binary rpms on all supported > architectures. > [ ]: SHOULD %check is present and all tests pass. > [ ]: SHOULD Packages should try to preserve timestamps of original installed > files. > [x]: SHOULD Spec use %global instead of %define. > > Issues: > [!]: MUST License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. No licenses > found. Please check the source files for licenses manually. > See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames Licensing seems correct, documented as a mix of Public Domain and BSD sources. Overall package should be considered as BSD licensed. > > Rpmlint > ------- > Checking: python-tlslite-0.4.1-1.fc17.src.rpm > python-tlslite-0.4.1-1.fc17.noarch.rpm > python-tlslite.src: W: spelling-error %description -l en_US crypto -> crypt, crypts, crypt o > python-tlslite.src: W: spelling-error %description -l en_US stdlib -> std lib, std-lib, stolid > python-tlslite.noarch: W: spelling-error %description -l en_US crypto -> crypt, crypts, crypt o > python-tlslite.noarch: W: spelling-error %description -l en_US stdlib -> std lib, std-lib, stolid > python-tlslite.noarch: W: no-manual-page-for-binary tls.py > python-tlslite.noarch: W: no-manual-page-for-binary tlsdb.py > 2 packages and 0 specfiles checked; 0 errors, 6 warnings. > I'm not sure if tls.py and tlsdb.py are important enough to the functioning of this package to warrant leaving them in bindir vs putting them in docdir. It looks like tls.py is more of a test script. tlsdb.py is used to manage SRP password databases, but it's use isn't well explained and outside of testing SRP with tls.py is probably best considered as a reference for developers. Other than that this all looks good to me. > > Rpmlint (installed packages) > ---------------------------- > Cannot parse rpmlint output: > Requires > -------- > python-tlslite-0.4.1-1.fc17.noarch.rpm (rpmlib, GLIBC filtered): > > /usr/bin/python > python(abi) = 2.7 > > Provides > -------- > python-tlslite-0.4.1-1.fc17.noarch.rpm: > > python-tlslite = 0.4.1-1.fc17 > > MD5-sum check > ------------- > https://github.com/downloads/trevp/tlslite/tlslite-0.4.1.tar.gz : > CHECKSUM(SHA256) this package : ae01fd74140cb00ca550304e41f5fe1a935cde1f1f4f351aed8861355bcd2047 > CHECKSUM(SHA256) upstream package : ae01fd74140cb00ca550304e41f5fe1a935cde1f1f4f351aed8861355bcd2047 > > > Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09 > Command line :/usr/bin/fedora-review -b 850504 > External plugins:
Thanks for the review. Updated: Spec URL: http://fedorapeople.org/~grover/new/python-tlslite.spec SRPM URL: http://fedorapeople.org/~grover/new/python-tlslite-0.4.1-2.el6.src.rpm
Thanks, updated package looks good to me.
New Package SCM Request ======================= Package Name: python-tlslite Short Description: Python module for SSL/TLS support Owners: grover Branches: f17 f18 InitialCC:
Git done (by process-git-requests).