Created attachment 606124 [details] filter more bad chars Description of problem: "git cvsimport" will choke if a CVS repository module contains a tag with weird characters. Version-Release number of selected component (if applicable): git-cvs-1.7.11.4-3.fc17.noarch Steps to Reproduce: 1. Create a tag in CVS with odd characters 2. Run "git cvsimport" 3. The cvsimport command fails Here's an example from RPM Fusion. One of the packages has a tag with "{", "}", and "?". I'm not sure which character is problematic. $ git cvsimport -a -d :ext:ktdreyer.org:/cvs/free dosemu -C dosemu [... snip ... ] Updated tag 'F-10-start' (was 0000000) Updated tag 'dosemu-1_4_0-3_1905svn' (was 0000000) fatal: 'dosemu-1_4_0-4_1905svn{?dist}' is not a valid tag name. Cannot create tag dosemu-1_4_0-4_1905svn{?dist}: and then cvsimport fails right there. Expected results: "git cvsimport" succeeds Additional info: I'm attaching a patch that fixes git-cvsimport for me. It deletes the three potentially-problematic characters from the tag name, similar to the filtering that's already present in the code.
I've got a better patch queued upstream here: http://www.mail-archive.com/git@vger.kernel.org/msg07479.html
Patch was merged upstream here: https://github.com/git/git/commit/70b67b0792375c59f60f3e24f2d6757b24dc719c
git-1.7.12.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/git-1.7.12.1-1.fc18
git-1.7.11.7-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/git-1.7.11.7-1.fc17
Package git-1.7.11.7-1.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing git-1.7.11.7-1.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-14977/git-1.7.11.7-1.fc17 then log in and leave karma (feedback).
This is already fixed in git-1.7.11.7-1.fc17