Bug 850640 - cvsimport should skip more characters
Summary: cvsimport should skip more characters
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: git
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adam Tkac
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-22 05:01 UTC by Ken Dreyer
Modified: 2013-04-30 23:52 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-11-22 15:51:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
filter more bad chars (375 bytes, patch)
2012-08-22 05:01 UTC, Ken Dreyer
no flags Details | Diff

Description Ken Dreyer 2012-08-22 05:01:57 UTC
Created attachment 606124 [details]
filter more bad chars

Description of problem:
"git cvsimport" will choke if a CVS repository module contains a tag with weird characters.

Version-Release number of selected component (if applicable):
git-cvs-1.7.11.4-3.fc17.noarch

Steps to Reproduce:
1. Create a tag in CVS with odd characters
2. Run "git cvsimport"
3. The cvsimport command fails
  
Here's an example from RPM Fusion. One of the packages has a tag with "{", "}", and "?". I'm not sure which character is problematic.

$ git cvsimport -a -d :ext:ktdreyer.org:/cvs/free dosemu -C dosemu
[... snip ... ]
Updated tag 'F-10-start' (was 0000000)
Updated tag 'dosemu-1_4_0-3_1905svn' (was 0000000)
fatal: 'dosemu-1_4_0-4_1905svn{?dist}' is not a valid tag name.
Cannot create tag dosemu-1_4_0-4_1905svn{?dist}: 

and then cvsimport fails right there.

Expected results:
"git cvsimport" succeeds

Additional info:
I'm attaching a patch that fixes git-cvsimport for me. It deletes the three potentially-problematic characters from the tag name, similar to the filtering that's already present in the code.

Comment 1 Ken Dreyer 2012-09-06 19:19:46 UTC
I've got a better patch queued upstream here: http://www.mail-archive.com/git@vger.kernel.org/msg07479.html

Comment 2 Ken Dreyer 2012-09-25 21:51:01 UTC
Patch was merged upstream here: https://github.com/git/git/commit/70b67b0792375c59f60f3e24f2d6757b24dc719c

Comment 3 Fedora Update System 2012-09-27 16:28:46 UTC
git-1.7.12.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/git-1.7.12.1-1.fc18

Comment 4 Fedora Update System 2012-09-27 16:29:05 UTC
git-1.7.11.7-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/git-1.7.11.7-1.fc17

Comment 5 Fedora Update System 2012-09-28 08:23:57 UTC
Package git-1.7.11.7-1.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing git-1.7.11.7-1.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-14977/git-1.7.11.7-1.fc17
then log in and leave karma (feedback).

Comment 6 Adam Tkac 2012-11-22 15:51:40 UTC
This is already fixed in git-1.7.11.7-1.fc17


Note You need to log in before you can comment on or make changes to this bug.