Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/compiz-plugins-unsupported.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/compiz-plugins-unsupported-0.8.8-1.fc17.src.rpm Description: The Compiz Fusion Project brings 3D desktop visual effects that improve usability of the X Window System and provide increased productivity though plugins and themes contributed by the community giving a rich desktop experience. Fedora Account System Username: raveit65
This is a re-review of a retired package.
New starting point. Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/compiz-plugins-unsupported.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/compiz-plugins-unsupported-0.8.8-4.fc18.src.rpm
Successful scratch build f19. http://koji.fedoraproject.org/koji/taskinfo?taskID=4797388 srpm link: http://kojipkgs.fedoraproject.org//work/tasks/7389/4797389/compiz-plugins-unsupported-0.8.8-4.fc19.src.rpm Ready for review.
new scratch build f19. http://koji.fedoraproject.org/koji/taskinfo?taskID=4820020 srpm link: http://kojipkgs.fedoraproject.org//work/tasks/21/4820021/compiz-plugins-unsupported-0.8.8-5.fc19.src.rpm Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/compiz-plugins-unsupported.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/compiz-plugins-unsupported-0.8.8-5.fc19.src.rpm
new scratch build for f19. * Sun Jan 13 2013 Wolfgang Ulbrich <chat-to-me> - 1:0.8.8-6 - obsolete compiz-fusion-unsupported http://koji.fedoraproject.org/koji/taskinfo?taskID=4864740 Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/compiz-plugins-unsupported.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/compiz-plugins-unsupported-0.8.8-6.fc19.src.rpm
APPROVED Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [-]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [?]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package devel [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/leigh/851805-compiz- plugins-unsupported/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: The spec file handles locales properly. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [?]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX / PatchY prefixed with %{name}. [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3932160 bytes in /usr/share 3932160 compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm Rpmlint ------- Checking: compiz-plugins-unsupported-debuginfo-0.8.8-6.fc19.x86_64.rpm compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm compiz-plugins-unsupported-devel-0.8.8-6.fc19.x86_64.rpm compiz-plugins-unsupported-0.8.8-6.fc19.src.rpm compiz-plugins-unsupported.x86_64: E: incorrect-fsf-address /usr/share/doc/compiz-plugins-unsupported-0.8.8/COPYING compiz-plugins-unsupported-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint compiz-plugins-unsupported compiz-plugins-unsupported- devel compiz-plugins-unsupported-debuginfo compiz-plugins-unsupported.x86_64: E: incorrect-fsf-address /usr/share/doc/compiz-plugins-unsupported-0.8.8/COPYING compiz-plugins-unsupported-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- compiz-plugins-unsupported-debuginfo-0.8.8-6.fc19.x86_64.rpm (rpmlib, GLIBC filtered): compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm (rpmlib, GLIBC filtered): compiz-plugins-main(x86-64) >= 0.8.8 libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXcomposite.so.1()(64bit) libXcursor.so.1()(64bit) libXdamage.so.1()(64bit) libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXinerama.so.1()(64bit) libXrandr.so.2()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libstartup-notification-1.so.0()(64bit) libxml2.so.2()(64bit) libxslt.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) compiz-plugins-unsupported-devel-0.8.8-6.fc19.x86_64.rpm (rpmlib, GLIBC filtered): compiz-plugins-main-devel(x86-64) >= 0.8.8 compiz-plugins-unsupported(x86-64) = 1:0.8.8-6.fc19 Provides -------- compiz-plugins-unsupported-debuginfo-0.8.8-6.fc19.x86_64.rpm: compiz-plugins-unsupported-debuginfo = 1:0.8.8-6.fc19 compiz-plugins-unsupported-debuginfo(x86-64) = 1:0.8.8-6.fc19 compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm: compiz-fusion-unsupported(x86-64) = 1:0.8.8-6.fc19 compiz-plugins-unsupported = 1:0.8.8-6.fc19 compiz-plugins-unsupported(x86-64) = 1:0.8.8-6.fc19 libatlantis.so()(64bit) libcubemodel.so()(64bit) libelements.so()(64bit) libfakeargb.so()(64bit) libmswitch.so()(64bit) libsnow.so()(64bit) libtile.so()(64bit) compiz-plugins-unsupported-devel-0.8.8-6.fc19.x86_64.rpm: compiz-fusion-unsupported-devel(x86-64) = 1:0.8.8-6.fc19 compiz-plugins-unsupported-devel = 1:0.8.8-6.fc19 compiz-plugins-unsupported-devel(x86-64) = 1:0.8.8-6.fc19 Unversioned so-files -------------------- compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm: /usr/lib64/compiz/libatlantis.so compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm: /usr/lib64/compiz/libcubemodel.so compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm: /usr/lib64/compiz/libelements.so compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm: /usr/lib64/compiz/libfakeargb.so compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm: /usr/lib64/compiz/libmswitch.so compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm: /usr/lib64/compiz/libsnow.so compiz-plugins-unsupported-0.8.8-6.fc19.x86_64.rpm: /usr/lib64/compiz/libtile.so MD5-sum check ------------- http://releases.compiz.org/0.8.8/compiz-plugins-unsupported-0.8.8.tar.bz2 : CHECKSUM(SHA256) this package : 0b2ed265eda34dd60e1155280cb944bef07499f5f8178fc2498c243b2809481e CHECKSUM(SHA256) upstream package : 0b2ed265eda34dd60e1155280cb944bef07499f5f8178fc2498c243b2809481e Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 851805
New Package SCM Request ======================= Package Name: compiz-plugins-unsupported Short Description: Additional plugins for Compiz Owners: raveit65 Branches: f18 InitialCC:
Git done (by process-git-requests).
Package Change Request ======================= Package Name: compiz-plugins-unsupported Short Description: Additional plugins for Compiz Owners: raveit65 Branches: f17 InitialCC:
NOTE: Misformatted request; using 'Branches' instead. WARNING: No new branches requested.
Package Change Request ====================== Package Name: compiz-plugins-unsupported New Branches: f17 Owners: raveit65 InitialCC: