Bug 851949 - [SetupNetworks] Need more validation for IP address field.
Summary: [SetupNetworks] Need more validation for IP address field.
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.1.0
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
: ---
Assignee: lpeer
QA Contact: Meni Yakove
URL:
Whiteboard: network
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-27 06:34 UTC by Meni Yakove
Modified: 2016-02-10 19:49 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-27 06:46:36 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
engine.log (716.66 KB, text/x-log)
2012-08-27 06:34 UTC, Meni Yakove
no flags Details
vdsm.log (3.60 MB, text/x-log)
2012-08-27 06:35 UTC, Meni Yakove
no flags Details

Description Meni Yakove 2012-08-27 06:34:16 UTC
Description of problem:
The validation on the IP address field is not complete, For example I can set IP address of 01.01.01.01 and this is not valid IP address. After apply and then open SetupNetworks again the static checkbox is selected but with empty IP address. 

Version-Release number of selected component (if applicable):
rhevm-3.1.0-13.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
1.Open SetupNetwork attache network to interface and set BOOTPROTO to static. Enter IP address 01.01.01.01 > Apply

  
Actual results:
Can set IP address of 01.01.01.01

Expected results:
Should get error about wrong IP address.

Comment 1 Meni Yakove 2012-08-27 06:34:43 UTC
Created attachment 607137 [details]
engine.log

Comment 2 Meni Yakove 2012-08-27 06:35:38 UTC
Created attachment 607138 [details]
vdsm.log

Comment 3 Itamar Heim 2012-08-27 06:39:50 UTC
I'd argue 01.01.01.01 is a legit ip address (both windows and linux accept it).

not sure why ipcalc doesn't

MainProcess|Thread-54412::INFO::2012-08-27 09:12:54,922::configNetwork::69::root::(ifup) Error adding address 01.01.01.01 for VM_VLAN_12.

MainProcess|Thread-54412::WARNING::2012-08-27 09:12:54,923::configNetwork::71::root::(ifup) ipcalc: bad IPv4 address: 01.01.01.01
ipcalc: bad IPv4 address: 01.01.01.01
ipcalc: bad IPv4 address: 01.01.01.01
Error: an inet prefix is expected rather than "01.01.01.01/".
bind: Cannot assign requested address


Note You need to log in before you can comment on or make changes to this bug.