Red Hat Bugzilla – Bug 851963
Guest will be undefined if remove channel content
Last modified: 2013-02-21 02:22:09 EST
Description of problem: Use virsh to edit the guest,remove <target type='virtio' name='com.redhat.spice.0'/>,then save. The guest will be undefined. Version-Release number of selected component (if applicable): libvirt-0.10.0-0rc1.el6.x86_64 How reproducible: always Steps to Reproduce: 1.Define a guest,add spicevmc channel. #virsh dumpxml kvm-win7-i386 ... <channel type='spicevmc'> <target type='virtio' name='com.redhat.spice.0'/> <address type='virtio-serial' controller='0' bus='0' port='1'/> </channel> ... 2.Edit the guest,remove <target type='virtio' name='com.redhat.spice.0'/> in channel.Then save. # virsh edit kvm-win7-i386 error: internal error Could not format channel target type Failed. Try again? [y,n,f,?]: 3.Type y,and exit. # virsh edit kvm-win7-i386 error: internal error Could not format channel target type Failed. Try again? [y,n,f,?]: error: Domain not found: no domain with matching uuid '46694cce-66a1-5264-16c0-da8d0980160a' # virsh start kvm-win7-i386 error: failed to get domain 'kvm-win7-i386' error: Domain not found: no domain with matching name 'kvm-win7-i386' Actual results: In steps 2,the guest was undefined. Expected results: The guest should not be undefined. Additional info: Libvirtd log: 2012-08-28 07:33:35.442+0000: 20908: error : virDomainChrDefaultTargetType:5085 : XML error: target type must be specified for channel device 2012-08-28 07:33:35.813+0000: 20908: error : virDomainChrDefFormat:12190 : internal error Could not format channel target type
Patch proposed upstream: https://www.redhat.com/archives/libvir-list/2012-August/msg01745.html
Moving to POST: commit 9eee40cc540e25bb0783ef393b7bf7a74444b55c Author: Michal Privoznik <mprivozn@redhat.com> AuthorDate: Mon Aug 27 17:40:33 2012 +0200 Commit: Michal Privoznik <mprivozn@redhat.com> CommitDate: Mon Aug 27 19:01:09 2012 +0200 qemu: Fix define logic With current flow in qemudDomainDefine we might lose data when updating an existing domain. We parse given XML and overwrite the configuration. Then we try to save the new config. However, this step may fail and we don't perform any roll back. In fact, we remove the domain from the list of domains held up by qemu driver. This is okay as long as the domain was brand new one. v0.10.0-rc1-38-g9eee40c
Verify this bug with libvirt-0.10.0-1.el6.x86_64. When edit the domain XML and remove <target type='virtio' name='com.redhat.spice.0'/>, it always can't save and there's two error log in libvirtd.log. 2012-08-30 09:41:16.726+0000: 10977: error : virDomainChrDefaultTargetType:5071 : XML error: target type must be specified for channel device 2012-08-30 09:41:16.993+0000: 10977: error : virDomainChrDefFormat:12183 : internal error Could not format channel target type So move this bug to VERIFIED.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2013-0276.html